evdev: Fix crashing with touch devices

ui/events/ozone/evdev/touch_event_converter.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/ozone/evdev/touch_event_converter.h"
 
 #include <fcntl.h>
 #include <linux/input.h>
 #include <poll.h>
 #include <stdio.h>
@@ skipping 128 matching lines @@
         case ABS_PRESSURE:
           altered_slots_.set(current_slot_);
           events_[current_slot_].pressure_ = input.value - pressure_min_;
           events_[current_slot_].pressure_ /= pressure_max_ - pressure_min_;
           break;
         case ABS_MT_SLOT:
           current_slot_ = input.value;
           altered_slots_.set(current_slot_);
           break;
         default:
-          NOTREACHED();
+          NOTREACHED() << "invalid code for EV_ABS: " << input.code;
       }
     } else if (input.type == EV_SYN) {
       switch (input.code) {
         case SYN_REPORT:
           for (int j = 0; j < MAX_FINGERS; j++) {
             if (altered_slots_[j]) {
               // TODO(rjkroege): Support elliptical finger regions.
               scoped_ptr<TouchEvent> tev(new TouchEvent(
                   events_[j].type_,
                   gfx::Point(std::min(x_max_, events_[j].x_),
@@ skipping 11 matching lines @@
               // Subsequent events for this finger will be touch-move until it
               // is released.
               events_[j].type_ = ET_TOUCH_MOVED;
             }
           }
           altered_slots_.reset();
           break;
         case SYN_MT_REPORT:
         case SYN_CONFIG:
         case SYN_DROPPED:
-          NOTREACHED() << "SYN_MT events not supported.";
+          NOTREACHED() << "invalid code for EV_SYN: " << input.code;
           break;
       }
+    } else if (input.type == EV_KEY) {

[rjkroege, 2013/11/04 23:39:46]

it is possible to get key events on the touchscreen fd? does this actually ever
happen?

[spang, 2013/11/05 00:10:02]

Yes it happens. Only the BTN_TOUCH "key".

+      switch (input.code) {
+        case BTN_TOUCH:
+          break;
+        default:
+          NOTREACHED() << "invalid code for EV_KEY: " << input.code;
+      }
     } else {
-      NOTREACHED();
+      NOTREACHED() << "invalid type: " << input.type;
     }
   }
 }
 
 }  // namespace ui