evdev: Fix crashing with touch devices

ui/events/ozone/evdev/event_device_info.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/events/ozone/evdev/event_device_info.h"
+
+#include <linux/input.h>
+
+#include "base/threading/thread_restrictions.h"
+
+namespace ui {
+
+namespace {
+
+bool GetEventBits(int fd, unsigned int type, void* buf, unsigned int size) {
+  return ioctl(fd, EVIOCGBIT(type, size), buf) < 0;
+}
+
+bool BitIsSet(const unsigned long* bits, unsigned int bit) {
+  return (bits[bit / EVDEV_LONG_BITS] & (1UL << (bit % EVDEV_LONG_BITS)));
+}
+
+}  // namespace
+
+EventDeviceInfo::EventDeviceInfo() {
+  memset(ev_bits_, 0, sizeof(ev_bits_));
+  memset(key_bits_, 0, sizeof(key_bits_));
+  memset(rel_bits_, 0, sizeof(rel_bits_));
+  memset(abs_bits_, 0, sizeof(abs_bits_));
+  memset(msc_bits_, 0, sizeof(msc_bits_));
+  memset(sw_bits_, 0, sizeof(sw_bits_));
+  memset(led_bits_, 0, sizeof(led_bits_));
+  memset(prop_bits_, 0, sizeof(prop_bits_));
+}
+
+EventDeviceInfo::~EventDeviceInfo() {}
+
+bool EventDeviceInfo::Initialize(int fd) {
+  base::ThreadRestrictions::AssertIOAllowed();
+
+  if (GetEventBits(fd, 0, ev_bits_, sizeof(ev_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_KEY, key_bits_, sizeof(key_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_REL, rel_bits_, sizeof(rel_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_ABS, abs_bits_, sizeof(abs_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_MSC, msc_bits_, sizeof(msc_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_SW, sw_bits_, sizeof(sw_bits_)))
+    return false;
+
+  if (GetEventBits(fd, EV_LED, led_bits_, sizeof(led_bits_)))
+    return false;
+
+  if (ioctl(fd, EVIOCGPROP(sizeof(prop_bits_)), prop_bits_))

[rjkroege, 2013/11/04 23:39:46]

you are not using the same ioctl as I was? 

And if it fails, some kind of diag would be desirable?

[spang, 2013/11/05 00:10:02]

I am above in GetEventbits; this one is different.

Added DLOG for failures.

+    return false;
+
+  return true;
+}
+
+bool EventDeviceInfo::HasEventType(unsigned int type) const {
+  if (type > EV_MAX)
+    return false;
+  return BitIsSet(ev_bits_, type);
+}
+
+bool EventDeviceInfo::HasKeyEvent(unsigned int code) const {
+  if (code > KEY_MAX)
+    return false;
+  return BitIsSet(key_bits_, code);
+}
+
+bool EventDeviceInfo::HasRelEvent(unsigned int code) const {
+  if (code > REL_MAX)
+    return false;
+  return BitIsSet(rel_bits_, code);
+}
+
+bool EventDeviceInfo::HasAbsEvent(unsigned int code) const {
+  if (code > ABS_MAX)
+    return false;
+  return BitIsSet(abs_bits_, code);
+}
+
+bool EventDeviceInfo::HasMscEvent(unsigned int code) const {
+  if (code > MSC_MAX)
+    return false;
+  return BitIsSet(msc_bits_, code);
+}
+
+bool EventDeviceInfo::HasSwEvent(unsigned int code) const {
+  if (code > SW_MAX)
+    return false;
+  return BitIsSet(sw_bits_, code);
+}
+
+bool EventDeviceInfo::hasLedEvent(unsigned int code) const {
+  if (code > LED_MAX)
+    return false;
+  return BitIsSet(led_bits_, code);
+}
+
+bool EventDeviceInfo::HasProp(unsigned int code) const {
+  if (code > INPUT_PROP_MAX)
+    return false;
+  return BitIsSet(prop_bits_, code);
+}
+
+}  // namespace ui