Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 584723002: Mojo: Add Channel::AttachEndpoint(), which takes a ChannelEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Add Channel::AttachEndpoint(), which takes a ChannelEndpoint. This will replace AttachMessagePipeEndpoint(), once I get rid of all the calls to it. (This change is required to move the "paused message queue" from the ProxyMessagePipeEndpoint to the ChannelEndpoint.) Also factor out the message writing (WriteMessageNoLock()) from the message enqueueing (EnqueueMessage()) in ChannelEndpoint. After I move the paused message queue to ChannelEndpoint, the latter will put stuff into said queue if it can't write. R=darin@chromium.org Committed: https://crrev.com/1a1d35bb2c9ec230d6a81999dbf555df290b2466 Cr-Commit-Position: refs/heads/master@{#295729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -19 lines) Patch
M mojo/system/channel.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mojo/system/channel.cc View 4 chunks +20 lines, -10 lines 0 comments Download
M mojo/system/channel_endpoint.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/system/channel_endpoint.cc View 2 chunks +19 lines, -7 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-18 22:56:34 UTC) #1
darin (slow to review)
LGTM
6 years, 3 months ago (2014-09-19 05:31:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584723002/1
6 years, 3 months ago (2014-09-19 17:21:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8db05d44c2d0ece2ebfcb93c92966a7140b49aa3
6 years, 3 months ago (2014-09-19 17:45:06 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:45:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a1d35bb2c9ec230d6a81999dbf555df290b2466
Cr-Commit-Position: refs/heads/master@{#295729}

Powered by Google App Engine
This is Rietveld 408576698