remoting/webapp/menu_button.js - Issue 584693003: Fix MenuButton for the case where multiple listeners are defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/menu_button.js

Issue 584693003: Fix MenuButton for the case where multiple listeners are defined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Temporarily disable unit test. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/webapp/menu_button.js

diff --git a/remoting/webapp/menu_button.js b/remoting/webapp/menu_button.js

index b41d69a3680d81f7a0b8e65ace3bc8677d496724..73c7642d1e12995b339dc54294ea9219f16a66a0 100644

--- a/remoting/webapp/menu_button.js

+++ b/remoting/webapp/menu_button.js

@@ -70,7 +70,7 @@ remoting.MenuButton = function(container, opt_onShow, opt_onHide) {

if (that.onShow_) {

that.onShow_();

}

- that.button_.classList.toggle(remoting.MenuButton.BUTTON_ACTIVE_CLASS_);

+ that.button_.classList.add(remoting.MenuButton.BUTTON_ACTIVE_CLASS_);

document.body.addEventListener('click', closeHandler, false);

event.stopPropagation();

};

« no previous file with comments | « no previous file | remoting/webapp/unittests/menu_button_unittest.js » ('j') | no next file with comments »