Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: ui/views/controls/webview/BUILD.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/BUILD.gn ('k') | ui/views/examples/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/BUILD.gn
diff --git a/ui/views/controls/webview/BUILD.gn b/ui/views/controls/webview/BUILD.gn
index 640a39edf707163026d2b8a4718c848032a9224d..93bd3608e40f3fe8605ce8e788398f4a201d7011 100644
--- a/ui/views/controls/webview/BUILD.gn
+++ b/ui/views/controls/webview/BUILD.gn
@@ -18,23 +18,24 @@ component("webview") {
defines = [ "WEBVIEW_IMPLEMENTATION" ]
deps = [
- "//base",
"//base:i18n",
"//base/third_party/dynamic_annotations",
- "//content/public/browser",
+ "//ipc",
"//skia",
"//ui/accessibility",
"//ui/base",
"//ui/events",
"//ui/events:events_base",
- "//ui/gfx",
- "//ui/gfx/geometry",
"//ui/web_dialogs",
- "//ui/views",
"//url",
]
- forward_dependent_configs_from = [
+ public_deps = [
+ "//base",
+ "//content/public/browser",
+ "//ui/aura",
+ "//ui/gfx",
+ "//ui/gfx/geometry",
"//ui/views",
]
}
@@ -46,8 +47,10 @@ source_set("test_support") {
"../../test/webview_test_helper.h",
]
- deps = [
+ public_deps = [
":webview",
+ ]
+ deps = [
"//base",
"//content",
"//content/test:test_support",
« no previous file with comments | « ui/views/BUILD.gn ('k') | ui/views/examples/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698