content/shell/BUILD.gn - Issue 584683002: Improve GN header checker, make //ui pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/BUILD.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/BUILD.gn

diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn

index 0c4168684fb33f93b7d81c6ebf7f89b773e26ba5..6d52357aab6978fe1d50200c6a97f9e96aeedfba 100644

--- a/content/shell/BUILD.gn

+++ b/content/shell/BUILD.gn

@@ -203,6 +203,15 @@ static_library("content_shell_lib") {

defines = [ "CONTENT_SHELL_VERSION=\"$content_shell_version\"" ]

+ public_deps = [

+ # This exposes all public content APIs.

+ "//content/public/app:both",

+ "//content/public/browser",

+ "//content/public/common",

+ "//content/public/plugin",

+ "//content/public/renderer",

+ "//content/public/utility",

+ ]

deps = [

":resources",

"//base",

@@ -216,12 +225,6 @@ static_library("content_shell_lib") {

"//content/app/resources",

"//content/app/strings",

"//content/gpu",

- "//content/public/app:both",

- "//content/public/browser",

- "//content/public/common",

- "//content/public/plugin",

- "//content/public/renderer",

- "//content/public/utility",

"//content/test:layouttest_support",

"//gin",

"//gpu",

« no previous file with comments | « cc/BUILD.gn ('k') | extensions/generated_extensions_api.gni » ('j') | no next file with comments »