build/config/BUILDCONFIG.gn - Issue 584683002: Improve GN header checker, make //ui pass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILDCONFIG.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/BUILDCONFIG.gn

diff --git a/build/config/BUILDCONFIG.gn b/build/config/BUILDCONFIG.gn

index 633283dfd708a2d283451f914990f20447d9d3d7..f20d7d07061ab354ea606a529c8331dff42381a1 100644

--- a/build/config/BUILDCONFIG.gn

+++ b/build/config/BUILDCONFIG.gn

@@ -550,6 +550,8 @@ template("component") {

if (defined(invoker.output_extension)) { output_extension = invoker.output_extension }

if (defined(invoker.output_name)) { output_name = invoker.output_name }

if (defined(invoker.public)) { public = invoker.public }

+ if (defined(invoker.public_configs)) { public_configs = invoker.public_configs }

+ if (defined(invoker.public_deps)) { public_deps = invoker.public_deps }

if (defined(invoker.sources)) { sources = invoker.sources }

if (defined(invoker.testonly)) { testonly = invoker.testonly }

if (defined(invoker.visibility)) { visibility = invoker.visibility }

@@ -584,6 +586,8 @@ template("component") {

if (defined(invoker.output_extension)) { output_extension = invoker.output_extension }

if (defined(invoker.output_name)) { output_name = invoker.output_name }

if (defined(invoker.public)) { public = invoker.public }

+ if (defined(invoker.public_configs)) { public_configs = invoker.public_configs }

+ if (defined(invoker.public_deps)) { public_deps = invoker.public_deps }

if (defined(invoker.sources)) { sources = invoker.sources }

if (defined(invoker.testonly)) { testonly = invoker.testonly }

if (defined(invoker.visibility)) { visibility = invoker.visibility }

@@ -632,6 +636,8 @@ template("test") {

if (defined(invoker.output_extension)) { output_extension = invoker.output_extension }

if (defined(invoker.output_name)) { output_name = invoker.output_name }

if (defined(invoker.public)) { public = invoker.public }

+ if (defined(invoker.public_configs)) { public_configs = invoker.public_configs }

+ if (defined(invoker.public_deps)) { public_deps = invoker.public_deps }

if (defined(invoker.sources)) { sources = invoker.sources }

if (defined(invoker.visibility)) { visibility = invoker.visibility }

}

@@ -667,6 +673,8 @@ template("test") {

if (defined(invoker.output_extension)) { output_extension = invoker.output_extension }

if (defined(invoker.output_name)) { output_name = invoker.output_name }

if (defined(invoker.public)) { public = invoker.public }

+ if (defined(invoker.public_configs)) { public_configs = invoker.public_configs }

+ if (defined(invoker.public_deps)) { public_deps = invoker.public_deps }

if (defined(invoker.sources)) { sources = invoker.sources }

if (defined(invoker.visibility)) { visibility = invoker.visibility }

}

« no previous file with comments | « base/test/BUILD.gn ('k') | cc/BUILD.gn » ('j') | no next file with comments »