Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: ui/views/BUILD.gn

Issue 584683002: Improve GN header checker, make //ui pass. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/controls/webview/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 7
8 gypi_values = exec_script( 8 gypi_values = exec_script(
9 "//build/gypi_to_gn.py", 9 "//build/gypi_to_gn.py",
10 [ rebase_path("views.gyp") ], 10 [ rebase_path("views.gyp") ],
11 "scope", 11 "scope",
12 [ "views.gyp" ]) 12 [ "views.gyp" ])
13 13
14 component("views") { 14 component("views") {
15 sources = gypi_values.views_sources 15 sources = gypi_values.views_sources
16 16
17 defines = [ "VIEWS_IMPLEMENTATION" ] 17 defines = [ "VIEWS_IMPLEMENTATION" ]
18 18
19 deps = [ 19 deps = [
20 "//base",
21 "//base:i18n", 20 "//base:i18n",
22 "//base/third_party/dynamic_annotations", 21 "//base/third_party/dynamic_annotations",
23 "//skia", 22 "//skia",
24 "//third_party/icu", 23 "//third_party/icu",
25 "//third_party/wtl", 24 "//third_party/wtl",
26 "//ui/accessibility", 25 "//ui/accessibility",
26 "//ui/aura",
27 "//ui/native_theme",
28 "//ui/resources",
29 "//ui/strings",
30 "//ui/wm",
31 "//url",
32 ]
33
34 public_deps = [
35 "//base",
27 "//ui/accessibility:ax_gen", 36 "//ui/accessibility:ax_gen",
28 "//ui/aura",
29 "//ui/base", 37 "//ui/base",
30 "//ui/compositor", 38 "//ui/compositor",
31 "//ui/events", 39 "//ui/events",
32 "//ui/events:events_base", 40 "//ui/events:events_base",
33 "//ui/events/platform", 41 "//ui/events/platform",
34 "//ui/gfx", 42 "//ui/gfx",
35 "//ui/gfx/geometry", 43 "//ui/gfx/geometry",
36 "//ui/native_theme",
37 "//ui/resources",
38 "//ui/strings",
39 "//ui/wm",
40 "//url",
41 ] 44 ]
42 45
43 forward_dependent_configs_from = [ "//ui/accessibility:ax_gen" ]
44
45 if (use_x11 && !is_chromeos) { 46 if (use_x11 && !is_chromeos) {
46 deps += [ "//ui/display/util" ] 47 deps += [ "//ui/display/util" ]
47 } 48 }
48 if (is_linux && !is_chromeos) { 49 if (is_linux && !is_chromeos) {
49 sources -= [ "window/window_button_order_provider.cc" ] 50 sources -= [ "window/window_button_order_provider.cc" ]
50 deps += [ "//ui/shell_dialogs" ] 51 deps += [ "//ui/shell_dialogs" ]
51 } else { 52 } else {
52 sources -= [ 53 sources -= [
53 "linux_ui/linux_ui.h", 54 "linux_ui/linux_ui.h",
54 "linux_ui/linux_ui.cc", 55 "linux_ui/linux_ui.cc",
(...skipping 23 matching lines...) Expand all
78 if (use_ozone) { 79 if (use_ozone) {
79 deps += [ "//ui/ozone" ] 80 deps += [ "//ui/ozone" ]
80 } 81 }
81 if (use_x11) { 82 if (use_x11) {
82 configs += [ 83 configs += [
83 "//build/config/linux:x11", 84 "//build/config/linux:x11",
84 "//build/config/linux:xrandr", 85 "//build/config/linux:xrandr",
85 ] 86 ]
86 deps += [ 87 deps += [
87 "//ui/events/platform/x11", 88 "//ui/events/platform/x11",
89 "//ui/gfx/x",
88 ] 90 ]
89 } 91 }
90 92
91 if (use_aura) { 93 if (use_aura) {
92 sources += gypi_values.views_aura_sources 94 sources += gypi_values.views_aura_sources
93 if (!is_chromeos) { 95 if (!is_chromeos) {
94 sources += gypi_values.views_desktop_aura_sources 96 sources += gypi_values.views_desktop_aura_sources
95 if (use_x11) { 97 if (use_x11) {
96 sources += gypi_values.views_desktop_aura_x11_sources 98 sources += gypi_values.views_desktop_aura_x11_sources
97 } else if (is_win) { 99 } else if (is_win) {
98 sources += gypi_values.views_desktop_aura_win_sources 100 sources += gypi_values.views_desktop_aura_win_sources
99 } else if (use_ozone) { 101 } else if (use_ozone) {
100 sources += gypi_values.views_desktop_aura_ozone_sources 102 sources += gypi_values.views_desktop_aura_ozone_sources
101 } 103 }
102 } 104 }
103 } 105 }
104 } 106 }
105 107
106 static_library("test_support") { 108 static_library("test_support") {
107 testonly = true 109 testonly = true
108 sources = gypi_values.views_test_support_sources 110 sources = gypi_values.views_test_support_sources
109 111
112 public_deps = [
113 ":views",
114 ]
110 deps = [ 115 deps = [
111 ":views",
112 "//base", 116 "//base",
113 "//ipc:test_support", 117 "//ipc:test_support",
114 "//skia", 118 "//skia",
115 "//testing/gtest", 119 "//testing/gtest",
116 "//ui/aura", 120 "//ui/aura",
117 "//ui/base", 121 "//ui/base",
118 "//ui/compositor", 122 "//ui/compositor",
119 "//ui/compositor:test_support", 123 "//ui/compositor:test_support",
120 "//ui/events", 124 "//ui/events",
121 "//ui/events:events_base", 125 "//ui/events:events_base",
122 "//ui/events:test_support", 126 "//ui/events:test_support",
123 "//ui/events/platform", 127 "//ui/events/platform",
124 "//ui/gfx", 128 "//ui/gfx",
125 "//ui/gfx/geometry", 129 "//ui/gfx/geometry",
126 "//ui/wm", 130 "//ui/wm",
127 ] 131 ]
128 132
129 if (is_chromeos) { 133 if (is_chromeos) {
130 sources -= [ 134 sources -= [
131 "test/ui_controls_factory_desktop_aurax11.cc", 135 "test/ui_controls_factory_desktop_aurax11.cc",
132 "test/ui_controls_factory_desktop_aurax11.h", 136 "test/ui_controls_factory_desktop_aurax11.h",
133 ] 137 ]
134 } 138 }
135 if (use_aura) { 139 if (use_aura) {
136 sources += gypi_values.views_test_support_aura_sources 140 sources += gypi_values.views_test_support_aura_sources
137 deps += [ "//ui/aura:test_support" ] 141 deps += [ "//ui/aura:test_support" ]
138 } 142 }
143 if (use_x11) {
144 deps += [ "//ui/gfx/x" ]
145 }
139 } 146 }
140 147
141 test("views_unittests") { 148 test("views_unittests") {
142 sources = gypi_values.views_unittests_sources 149 sources = gypi_values.views_unittests_sources
143 150
144 deps = [ 151 deps = [
145 ":test_support", 152 ":test_support",
146 ":views",
147 "//base", 153 "//base",
148 "//base:i18n", 154 "//base:i18n",
149 "//base/allocator", 155 "//base/allocator",
150 "//base/test:test_support", 156 "//base/test:test_support",
151 "//skia", 157 "//skia",
152 "//testing/gtest", 158 "//testing/gtest",
153 "//third_party/icu", 159 "//third_party/icu",
154 "//ui/accessibility", 160 "//ui/accessibility",
155 "//ui/aura", 161 "//ui/aura",
156 "//ui/base", 162 "//ui/base",
157 "//ui/base:test_support", 163 "//ui/base:test_support",
158 "//ui/compositor", 164 "//ui/compositor:test_support",
159 "//ui/events", 165 "//ui/events:test_support",
160 "//ui/events:events_base", 166 "//ui/events:events_base",
161 "//ui/events/platform", 167 "//ui/events/platform",
162 "//ui/gfx", 168 "//ui/gfx",
163 "//ui/gfx/geometry", 169 "//ui/gfx/geometry",
164 "//ui/gl", 170 "//ui/gl",
171 "//ui/resources",
172 "//ui/strings",
165 "//ui/wm", 173 "//ui/wm",
166 "//url", 174 "//url",
167 ] 175 ]
168 176
169 if (is_chromeos) { 177 if (is_chromeos) {
170 sources -= [ 178 sources -= [
171 "ime/input_method_bridge_unittest.cc", 179 "ime/input_method_bridge_unittest.cc",
172 ] 180 ]
173 } 181 }
174 182
(...skipping 17 matching lines...) Expand all
192 #}, 200 #},
193 } 201 }
194 202
195 if (use_x11) { 203 if (use_x11) {
196 configs += [ 204 configs += [
197 "//build/config/linux:x11", 205 "//build/config/linux:x11",
198 "//build/config/linux:xext", 206 "//build/config/linux:xext",
199 ] 207 ]
200 deps += [ 208 deps += [
201 "//ui/events/platform/x11", 209 "//ui/events/platform/x11",
210 "//ui/gfx/x",
202 ] 211 ]
203 } 212 }
204 213
205 if (use_aura) { 214 if (use_aura) {
206 sources += gypi_values.views_unittests_aura_sources 215 sources += gypi_values.views_unittests_aura_sources
207 deps += [ "//ui/aura:test_support" ] 216 deps += [ "//ui/aura:test_support" ]
208 if (!is_chromeos) { 217 if (!is_chromeos) {
209 sources += gypi_values.views_unittests_desktop_aura_sources 218 sources += gypi_values.views_unittests_desktop_aura_sources
210 } 219 }
211 } 220 }
212 if (use_x11) { 221 if (use_x11) {
213 deps += [ "//ui/events/platform/x11" ] 222 deps += [
223 "//ui/events/platform/x11",
224 "//ui/gfx/x",
225 ]
214 } 226 }
215 227
216 if (is_mac) { 228 if (is_mac) {
217 # views_unittests not yet compiling on Mac. http://crbug.com/378134 229 # views_unittests not yet compiling on Mac. http://crbug.com/378134
218 sources -= [ 230 sources -= [
219 "bubble/bubble_window_targeter_unittest.cc", 231 "bubble/bubble_window_targeter_unittest.cc",
220 "controls/button/custom_button_unittest.cc", 232 "controls/button/custom_button_unittest.cc",
221 "controls/button/menu_button_unittest.cc", 233 "controls/button/menu_button_unittest.cc",
222 "controls/native/native_view_host_unittest.cc", 234 "controls/native/native_view_host_unittest.cc",
223 "controls/menu/menu_controller_unittest.cc", 235 "controls/menu/menu_controller_unittest.cc",
(...skipping 20 matching lines...) Expand all
244 "//testing/gtest", 256 "//testing/gtest",
245 "//ui/aura", 257 "//ui/aura",
246 "//ui/compositor", 258 "//ui/compositor",
247 "//ui/resources", 259 "//ui/resources",
248 "//ui/resources:ui_test_pak", 260 "//ui/resources:ui_test_pak",
249 "//ui/strings", 261 "//ui/strings",
250 "//ui/wm", 262 "//ui/wm",
251 ] 263 ]
252 } 264 }
253 } 265 }
OLDNEW
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/controls/webview/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698