Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 584673002: Roll asan_symbolize.py to llvm r218071. (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll asan_symbolize.py to llvm r218071. This fixes an issue with missing newlines in stacktraces. BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/f7aef702936dcd93ab4928ead74e3db437c1f862 Cr-Commit-Position: refs/heads/master@{#295531}

Patch Set 1 #

Patch Set 2 : update documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -19 lines) Patch
M tools/valgrind/asan/third_party/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/asan/third_party/asan_symbolize.py View 8 chunks +54 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 3 months ago (2014-09-18 19:38:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584673002/20001
6 years, 3 months ago (2014-09-18 19:39:59 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e608fc0ff7f84ca04bed228175b0165db48a47cb
6 years, 3 months ago (2014-09-18 19:41:09 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f7aef702936dcd93ab4928ead74e3db437c1f862 Cr-Commit-Position: refs/heads/master@{#295531}
6 years, 3 months ago (2014-09-18 19:42:10 UTC) #5
earthdok
6 years, 3 months ago (2014-09-18 19:53:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/580233003/ by earthdok@chromium.org.

The reason for reverting is: This requires an accompanying change to the
Chromium-specific wrapper.

NOTRY=true.

Powered by Google App Engine
This is Rietveld 408576698