Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 584633004: Remove incorrect ASSERT from HTMLMediaElement::hasPendingElement (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-18 20:35:52 UTC) #1
Dirk Pranke
rubber-stamp lgtm.
6 years, 3 months ago (2014-09-18 20:36:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/584633004/1
6 years, 3 months ago (2014-09-18 20:38:53 UTC) #4
philipj_slow
Thanks, I'll investigate why if failed and if it can be put back tomorrow.
6 years, 3 months ago (2014-09-18 21:06:58 UTC) #5
Ken Russell (switch to Gerrit)
Thanks for helping move this fix forward. Reference bug 400659?
6 years, 3 months ago (2014-09-18 21:13:43 UTC) #6
philipj_slow
Yeah, if anyone can make it BUG=400659 before CQ commits this, please do so :)
6 years, 3 months ago (2014-09-18 21:17:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/584633004/1
6 years, 3 months ago (2014-09-18 21:18:28 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 22:01:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182278

Powered by Google App Engine
This is Rietveld 408576698