Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 584623003: Fix Chrome component build. (Closed)

Created:
6 years, 3 months ago by perkj_chrome
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This fixes a component build breakage introduced by the latest WebRtc roll to r7234. The missing symbol on linux was: _ZN6webrtc18videocapturemodule16VideoCaptureImpl6CreateEiPKc TBR=sergeyu@chromium.org Committed: https://crrev.com/dd449e72e25d814f1915ff0dea337d9f733aabef Cr-Commit-Position: refs/heads/master@{#295698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
perkj_chrome
Please?
6 years, 3 months ago (2014-09-19 12:44:09 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-09-19 12:45:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584623003/1
6 years, 3 months ago (2014-09-19 12:49:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/12106)
6 years, 3 months ago (2014-09-19 12:58:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584623003/1
6 years, 3 months ago (2014-09-19 13:15:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8feb8f246614a6d116308cbc437bda68fcba6edc
6 years, 3 months ago (2014-09-19 13:48:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 13:49:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd449e72e25d814f1915ff0dea337d9f733aabef
Cr-Commit-Position: refs/heads/master@{#295698}

Powered by Google App Engine
This is Rietveld 408576698