Issue 584573003: Add JSBuiltinReducer for inlining well-known builtins.

Issue 584573003: Add JSBuiltinReducer for inlining well-known builtins. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Add JSBuiltinReducer for inlining well-known builtins. R=titzer@chromium.org TEST=cctest/test-js-typed-lowering/BuiltinMathImul Committed: https://code.google.com/p/v8/source/detail?r=24095

Patch Set 2 : Remove debug code. #

Patch Set 3 : Add a unit test. #

Total comments: 4

Patch Set 4 : Addressed comments by Ben Titzer. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -3 lines)			Patch
M	BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/compiler/js-builtin-reducer.h	View	1 2 3	1 chunk	+42 lines, -0 lines	0 comments	Download
A	src/compiler/js-builtin-reducer.cc	View	1 2 3	1 chunk	+111 lines, -0 lines	0 comments	Download
M	src/compiler/js-typed-lowering.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	1 2	2 chunks	+32 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Still needs tests, but the code is ready for a first round.

6 years, 3 months ago (2014-09-18 17:21:37 UTC) #1

titzer

https://codereview.chromium.org/584573003/diff/40001/src/compiler/js-builtin-reducer.cc File src/compiler/js-builtin-reducer.cc (right): https://codereview.chromium.org/584573003/diff/40001/src/compiler/js-builtin-reducer.cc#newcode67 src/compiler/js-builtin-reducer.cc:67: return OperatorProperties::GetValueInputCount(node_->op()) - 2; +/- magic numbers should be ...

6 years, 3 months ago (2014-09-19 11:06:15 UTC) #3

Michael Starzinger

Addressed comments. https://codereview.chromium.org/584573003/diff/40001/src/compiler/js-builtin-reducer.cc File src/compiler/js-builtin-reducer.cc (right): https://codereview.chromium.org/584573003/diff/40001/src/compiler/js-builtin-reducer.cc#newcode67 src/compiler/js-builtin-reducer.cc:67: return OperatorProperties::GetValueInputCount(node_->op()) - 2; On 2014/09/19 11:06:15, ...

6 years, 3 months ago (2014-09-19 11:18:30 UTC) #4

Michael Starzinger

6 years, 3 months ago (2014-09-19 15:03:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as 24095 (presubmit successful).

Expand Messages | Collapse Messages