chrome/chrome.isolate - Issue 584553006: Don't include nacl_irt_x86_64.nexe in isolate for 32 bit Linux builds which don't have it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.isolate

Issue 584553006: Don't include nacl_irt_x86_64.nexe in isolate for 32 bit Linux builds which don't have it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome.isolate

diff --git a/chrome/chrome.isolate b/chrome/chrome.isolate

index c59555ff7838487bc0f4e0553eb84669840ba9e9..e785b5c8d66a04985ecaabf7f6d7baab5506b9f5 100644

--- a/chrome/chrome.isolate

+++ b/chrome/chrome.isolate

@@ -30,13 +30,19 @@

'<(PRODUCT_DIR)/chrome_100_percent.pak',

'<(PRODUCT_DIR)/locales/en-US.pak',

'<(PRODUCT_DIR)/locales/fr.pak',

- '<(PRODUCT_DIR)/nacl_irt_x86_64.nexe',

'isolate_dependency_untracked': [

'<(PRODUCT_DIR)/resources/extension/',

}],

+ ['OS=="win" or (OS=="linux" and target_arch=="x64"', {

Dan Beam 2014/09/18 20:44:46 doesn't this need a closing )?

jam 2014/09/18 20:45:19 yep had put it right after I sent it :)

+ 'variables': {

+ 'isolate_dependency_tracked': [

+ '<(PRODUCT_DIR)/nacl_irt_x86_64.nexe',

+ ],

+ },

+ }],

['OS=="mac"', {

'variables': {

'command': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »