Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 584553006: Don't include nacl_irt_x86_64.nexe in isolate for 32 bit Linux builds which don't have it. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't include nacl_irt_x86_64.nexe in isolate for 32 bit Linux builds which don't have it. This is breaking after r295514 which enforces that every file listed in an isolate file exists. BUG=414808 R=erg@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/aeae967ce9fd0b084bf7ab55a8e40a1eaf80afd0

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/chrome.isolate View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Elliot Glaysher
lgtm
6 years, 3 months ago (2014-09-18 20:44:11 UTC) #1
Dan Beam
https://codereview.chromium.org/584553006/diff/1/chrome/chrome.isolate File chrome/chrome.isolate (right): https://codereview.chromium.org/584553006/diff/1/chrome/chrome.isolate#newcode39 chrome/chrome.isolate:39: ['OS=="win" or (OS=="linux" and target_arch=="x64"', { doesn't this need ...
6 years, 3 months ago (2014-09-18 20:44:46 UTC) #3
jam
https://codereview.chromium.org/584553006/diff/1/chrome/chrome.isolate File chrome/chrome.isolate (right): https://codereview.chromium.org/584553006/diff/1/chrome/chrome.isolate#newcode39 chrome/chrome.isolate:39: ['OS=="win" or (OS=="linux" and target_arch=="x64"', { On 2014/09/18 20:44:46, ...
6 years, 3 months ago (2014-09-18 20:45:19 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aeae967ce9fd0b084bf7ab55a8e40a1eaf80afd0 Cr-Commit-Position: refs/heads/master@{#295548}
6 years, 3 months ago (2014-09-18 20:49:05 UTC) #5
jam
6 years, 3 months ago (2014-09-18 20:49:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as aeae967 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698