New Chromedriver test to install and launch remoting apps from CWS.

A script for smoke-testing remoting webapps.

BUG=

Committed: https://crrev.com/7a1d31b828ffb9b8db4181f08514ae5e78ea7b7f
Cr-Commit-Position: refs/heads/master@{#295827}

[anandc, 2014-09-18 15:21:52]

anandc@chromium.org changed reviewers:
+ garykac@chromium.org

[anandc, 2014-09-18 15:21:53]

Hi Gary, PTAL. Thanks.

[garykac, 2014-09-18 23:33:16]

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
File chrome/test/remoting/install_and_launch_app.py (right):

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:109: # TODO(anandc): add check to
make sure the app we are testing isn't already
nit: "Add"

(and "Is" below)

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:125: time.sleep(2)
Not sure if it's worth doing, but these time.sleep(2)s could be put into a
wait() function, or the 2 could be made a constant. This would make it easier to
experiment with different values.

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:139: # and launch it. (2 GET
calls again, once is not enough; see not above.)
The code will be a bit easier to follow if you have a method that wraps these 2
gets together. That'll make this code easier to read and will move all the
comments about the problem into one place.

def get_wait(link):
  """ We need to 'get' it twice because ...
  """
  driver.get(link)
  driver.get(link)
  time.sleep(2)

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:144: launch_button =
driver.find_element_by_xpath(LAUNCH_BUTTON_XPATH)
This chunk can be re-used as well:

def click_wait(button_xpath):
  button = driver.find_element_by_xpath(button_xpath)
  button.click()
  time.sleep(2)

Then this try-block becomes something like:

  chrome_apps_link = 'chrome://apps'
  cws_app_detail_link = '%s/%s' % (CWS_URL, args.app_id)

  get_wait(chrome_apps_link)
  get_wait(cws_app_detail_link)
  click_wait(FREE_BUTTON_XPATH)

  # Switch tab...

  get_wait(cws_app_detail_link)
  click_wait(LAUNCH_BUTTON_XPATH)

  # Check connecting dialog...

[anandc, 2014-09-19 21:05:32]

Thank you, Gary. PTAL.

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
File chrome/test/remoting/install_and_launch_app.py (right):

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:109: # TODO(anandc): add check to
make sure the app we are testing isn't already
On 2014/09/18 23:33:16, garykac wrote:
> nit: "Add"
> 
> (and "Is" below)

Done.

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:125: time.sleep(2)
On 2014/09/18 23:33:16, garykac wrote:
> Not sure if it's worth doing, but these time.sleep(2)s could be put into a
> wait() function, or the 2 could be made a constant. This would make it easier
to
> experiment with different values.

Done.

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:139: # and launch it. (2 GET
calls again, once is not enough; see not above.)
On 2014/09/18 23:33:16, garykac wrote:
> The code will be a bit easier to follow if you have a method that wraps these
2
> gets together. That'll make this code easier to read and will move all the
> comments about the problem into one place.
> 
> def get_wait(link):
>   """ We need to 'get' it twice because ...
>   """
>   driver.get(link)
>   driver.get(link)
>   time.sleep(2)

Makes sense. Thanks. 

Done, with a slight difference: 
call the function twice when going to the app-detail page, rather than have 2
gets within the function.

https://codereview.chromium.org/584543003/diff/1/chrome/test/remoting/install...
chrome/test/remoting/install_and_launch_app.py:144: launch_button =
driver.find_element_by_xpath(LAUNCH_BUTTON_XPATH)
On 2014/09/18 23:33:16, garykac wrote:
> This chunk can be re-used as well:
> 
> def click_wait(button_xpath):
>   button = driver.find_element_by_xpath(button_xpath)
>   button.click()
>   time.sleep(2)
> 
> Then this try-block becomes something like:
> 
>   chrome_apps_link = 'chrome://apps'
>   cws_app_detail_link = '%s/%s' % (CWS_URL, args.app_id)
> 
>   get_wait(chrome_apps_link)
>   get_wait(cws_app_detail_link)
>   click_wait(FREE_BUTTON_XPATH)
> 
>   # Switch tab...
> 
>   get_wait(cws_app_detail_link)
>   click_wait(LAUNCH_BUTTON_XPATH)
> 
>   # Check connecting dialog...

Done.

[garykac1, 2014-09-19 21:26:47]

garykac@google.com changed reviewers:
+ garykac@google.com

[garykac1, 2014-09-19 21:26:48]

lgtm

[anandc, 2014-09-19 22:35:16]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:36:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584543003/20001

[commit-bot: I haz the power, 2014-09-19 23:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:01:03]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-19 23:01:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:01:44]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[garykac, 2014-09-19 23:39:16]

lgtm

[garykac, 2014-09-19 23:39:23]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2014-09-19 23:41:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584543003/20001

[commit-bot: I haz the power, 2014-09-20 00:19:50]

Committed patchset #2 (id:20001) as 33ac986f1e0a9d5c9d0fd49bd5d12ff90bb5b77d

[commit-bot: I haz the power, 2014-09-20 00:20:24]

Patchset 2 (id:??) landed as
https://crrev.com/7a1d31b828ffb9b8db4181f08514ae5e78ea7b7f
Cr-Commit-Position: refs/heads/master@{#295827}