Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 584523003: Create org.chromium.content_public.common and move two classes there. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@use_display_in_shortcuthelper
Project:
chromium
Visibility:
Public.

Description

Create org.chromium.content_public.common and move two classes there. ScreenOrientationValues and Referrer are being moved there. Another class regarding shortcuts and default orientaiton will also be added. BUG=366145 TBR=avi@chromium.org (for content/content.gyp) Committed: https://crrev.com/c806854f11967371b4f2fd87b91a3706077776b1 Cr-Commit-Position: refs/heads/master@{#295473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -65 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +1 line, -1 line 0 comments Download
M android_webview/java_library_common.mk View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItemDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/EmptyChromeContextMenuItemDelegate.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java View 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java View 1 chunk +1 line, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/common/ScreenOrientationValues.template View 1 chunk +0 lines, -11 lines 0 comments Download
D content/public/android/java/src/org/chromium/content_public/Referrer.java View 1 chunk +0 lines, -27 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/LoadUrlParams.java View 2 chunks +13 lines, -13 lines 0 comments Download
A + content/public/android/java/src/org/chromium/content_public/common/Referrer.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/android/java/src/org/chromium/content_public/common/ScreenOrientationValues.template View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
mlamouri (slow - plz ping)
6 years, 3 months ago (2014-09-18 13:23:31 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-18 13:34:01 UTC) #3
mlamouri (slow - plz ping)
+benm@ for OWNER review.
6 years, 3 months ago (2014-09-18 13:36:22 UTC) #5
benm (inactive)
lgtm
6 years, 3 months ago (2014-09-18 14:06:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584523003/1
6 years, 3 months ago (2014-09-18 14:08:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as f860f19c10c21159565868c85ae63105d3a0f2ab
6 years, 3 months ago (2014-09-18 15:58:44 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 15:59:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c806854f11967371b4f2fd87b91a3706077776b1
Cr-Commit-Position: refs/heads/master@{#295473}

Powered by Google App Engine
This is Rietveld 408576698