Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 584513004: Forcibly terminate the metro viewer (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Forcibly terminate the metro viewer On trybots, the viewer shutdown is frequently taking 16s, making ash_unittests as a whole take ~20m. Killing the viewer more aggressively makes all the tests run at the "normal" time in the 1-500ms range, dropping total time to 5-6m. R=cpu@chromium.org BUG=411147 Committed: https://crrev.com/921a7f3597fbab7c94e82910bf9e7c40616b44e0 Cr-Commit-Position: refs/heads/master@{#295749}

Patch Set 1 #

Patch Set 2 : another attempt #

Patch Set 3 : no viewer #

Patch Set 4 : 'fix' bot mode #

Patch Set 5 : . #

Patch Set 6 : more in tear down #

Patch Set 7 : more timers #

Patch Set 8 : try TerminateProcess #

Patch Set 9 : revert the rest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
scottmg
6 years, 3 months ago (2014-09-19 04:48:10 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 3 months ago (2014-09-19 18:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584513004/150001
6 years, 3 months ago (2014-09-19 18:18:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584513004/150001
6 years, 3 months ago (2014-09-19 18:45:12 UTC) #8
commit-bot: I haz the power
Committed patchset #9 (id:150001) as e793e9c1124aa1fd6f5b260f6d91b951c234283a
6 years, 3 months ago (2014-09-19 18:47:50 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 18:49:27 UTC) #10
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/921a7f3597fbab7c94e82910bf9e7c40616b44e0
Cr-Commit-Position: refs/heads/master@{#295749}

Powered by Google App Engine
This is Rietveld 408576698