Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 584513003: Move extension_test_message_listener to extensions. (Closed)

Created:
6 years, 3 months ago by lfg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, vandebo (ex-Chrome), felt, nkostylev+watch_chromium.org, hguihot+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, rginda+watch_chromium.org, yusukes+watch_chromium.org, sadrul, stevenjb+watch_chromium.org, mikhal+watch_chromium.org, extensions-reviews_chromium.org, gab+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, jennb, imcheng+watch_chromium.org, jasonroberts+watch_google.com, jianli, rlp+watch_chromium.org, oshima+watch_chromium.org, kalyank, chrome-apps-syd-reviews_chromium.org, hclam+watch_chromium.org, erikwright+watch_chromium.org, Lei Zhang, tfarina, avayvod+watch_chromium.org, Dmitry Titov, robertshield+watch_chromium.org, pwestin+watch_google.com, tommycli, ben+ash_chromium.org, Greg Billock, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move extension_test_message_listener to extensions. This CL is part of the refactoring of webview into extensions/, and the webview test infrastructure depends heavily on this. Webview tests will be added to extensions soon. BUG=352290 Committed: https://crrev.com/910f2f9803b96e22989b6ac2ea80a50c49b9d20f Cr-Commit-Position: refs/heads/master@{#295665}

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Fix include guard #

Patch Set 4 : gn build #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -378 lines) Patch
M apps/app_restore_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_shim/app_shim_interactive_uitest_mac.mm View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M apps/load_and_launch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_browsertest_util.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_crash_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_pointer_lock_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_url_redirector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_window_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_window_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/event_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/apps/window_controls_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_script_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/ad_injection_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/all_urls_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/audio/audio_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_streaming/performance_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/media_galleries_private/media_galleries_watch_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/music_manager_private_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preferences_private/preferences_private_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_network/system_network_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_eject_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_performancetest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_storage_monitor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_test_message_listener.h View 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/extensions/extension_test_message_listener.cc View 1 chunk +0 lines, -116 lines 0 comments Download
M chrome/browser/extensions/extension_test_message_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webui_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/shared_module_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/location_bar/location_bar_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_extension_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/app_window/app_window_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/test/extension_test_message_listener.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/test/extension_test_message_listener.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
lfg
yoz@: PTAL?
6 years, 3 months ago (2014-09-18 20:54:35 UTC) #2
Yoyo Zhou
LGTM, are there any appropriate BUG=?
6 years, 3 months ago (2014-09-18 21:31:49 UTC) #3
lfg
I'm not sure if there's an appropriate BUG=, I was hoping you could point me ...
6 years, 3 months ago (2014-09-18 21:41:04 UTC) #5
lfg
sky@chromium.org: Please review changes in chrome/browser/*
6 years, 3 months ago (2014-09-18 21:42:47 UTC) #7
Yoyo Zhou
On 2014/09/18 21:41:04, lfg wrote: > I'm not sure if there's an appropriate BUG=, I ...
6 years, 3 months ago (2014-09-18 21:42:58 UTC) #8
lfg
On 2014/09/18 21:42:58, Yoyo Zhou wrote: > On 2014/09/18 21:41:04, lfg wrote: > > I'm ...
6 years, 3 months ago (2014-09-18 21:44:42 UTC) #9
James Cook
On 2014/09/18 21:42:58, Yoyo Zhou wrote: > On 2014/09/18 21:41:04, lfg wrote: > > I'm ...
6 years, 3 months ago (2014-09-18 21:46:01 UTC) #10
James Cook
On 2014/09/18 21:46:01, James Cook wrote: > On 2014/09/18 21:42:58, Yoyo Zhou wrote: > > ...
6 years, 3 months ago (2014-09-18 21:47:20 UTC) #11
lfg
On 2014/09/18 21:47:20, James Cook wrote: > On 2014/09/18 21:46:01, James Cook wrote: > > ...
6 years, 3 months ago (2014-09-18 21:49:34 UTC) #12
sky
LGTM
6 years, 3 months ago (2014-09-18 23:41:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584513003/80001
6 years, 3 months ago (2014-09-19 05:02:21 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 700ea9694972b9061554d420a20870b258d7c277
6 years, 3 months ago (2014-09-19 05:31:21 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 05:32:09 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/910f2f9803b96e22989b6ac2ea80a50c49b9d20f
Cr-Commit-Position: refs/heads/master@{#295665}

Powered by Google App Engine
This is Rietveld 408576698