Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: cc/layers/layer.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update unittests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/layer.h
diff --git a/cc/layers/layer.h b/cc/layers/layer.h
index 3452e8b157b6b63477b20ff69b27deca5f8ee018..e6283a589d1673c8cfca682f68b5769db5850652 100644
--- a/cc/layers/layer.h
+++ b/cc/layers/layer.h
@@ -261,9 +261,9 @@ class CC_EXPORT Layer : public base::RefCounted<Layer>,
return draw_properties_.num_unclipped_descendants;
}
- void SetScrollOffset(gfx::Vector2d scroll_offset);
- gfx::Vector2d scroll_offset() const { return scroll_offset_; }
- void SetScrollOffsetFromImplSide(const gfx::Vector2d& scroll_offset);
+ void SetScrollOffset(gfx::Vector2dF scroll_offset);
danakj 2014/09/18 21:21:52 this should be a const& while you're here
Yufeng Shen (Slow to review) 2014/09/18 22:47:55 Done.
+ gfx::Vector2dF scroll_offset() const { return scroll_offset_; }
+ void SetScrollOffsetFromImplSide(const gfx::Vector2dF& scroll_offset);
void SetScrollClipLayerId(int clip_layer_id);
bool scrollable() const { return scroll_clip_layer_id_ != INVALID_ID; }
@@ -584,7 +584,7 @@ class CC_EXPORT Layer : public base::RefCounted<Layer>,
// Layer properties.
gfx::Size bounds_;
- gfx::Vector2d scroll_offset_;
+ gfx::Vector2dF scroll_offset_;
// This variable indicates which ancestor layer (if any) whose size,
// transformed relative to this layer, defines the maximum scroll offset for
// this layer.

Powered by Google App Engine
This is Rietveld 408576698