ui/gfx/geometry/safe_integer_conversions_unittest.cc - Issue 584503005: Make scroll offset type of float in cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/geometry/safe_integer_conversions_unittest.cc

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: link crbug to TODO Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/geometry/safe_integer_conversions_unittest.cc

diff --git a/ui/gfx/geometry/safe_integer_conversions_unittest.cc b/ui/gfx/geometry/safe_integer_conversions_unittest.cc

index e00671b264a5869c3a7d585ab84f3b8d184d18e2..20e05b49e0f6caaab79d14380b73ce0d4b53ad84 100644

--- a/ui/gfx/geometry/safe_integer_conversions_unittest.cc

+++ b/ui/gfx/geometry/safe_integer_conversions_unittest.cc

@@ -48,7 +48,7 @@ TEST(SafeIntegerConversions, ToFlooredInt) {

EXPECT_EQ(int_max, ToFlooredInt(max + 100));

EXPECT_EQ(-101, ToFlooredInt(-100.5f));

- EXPECT_EQ(0, ToFlooredInt(0));

+ EXPECT_EQ(0, ToFlooredInt(0.f));

EXPECT_EQ(100, ToFlooredInt(100.5f));

EXPECT_EQ(int_min, ToFlooredInt(-infinity));

@@ -71,7 +71,7 @@ TEST(SafeIntegerConversions, ToCeiledInt) {

EXPECT_EQ(int_max, ToCeiledInt(max + 100));

EXPECT_EQ(-100, ToCeiledInt(-100.5f));

- EXPECT_EQ(0, ToCeiledInt(0));

+ EXPECT_EQ(0, ToCeiledInt(0.f));

EXPECT_EQ(101, ToCeiledInt(100.5f));

EXPECT_EQ(int_min, ToCeiledInt(-infinity));

« no previous file with comments | « ui/gfx/geometry/safe_integer_conversions.h ('k') | ui/gfx/geometry/scroll_offset.h » ('j') | no next file with comments »