Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2495)

Unified Diff: cc/animation/layer_animation_controller.cc

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: link crbug to TODO Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/animation/layer_animation_controller.h ('k') | cc/animation/layer_animation_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/layer_animation_controller.cc
diff --git a/cc/animation/layer_animation_controller.cc b/cc/animation/layer_animation_controller.cc
index 08a0ee91f1854cf4fc5020b50d8996803a9f1c01..04fff1878992fcb309f1b9d439a57173d6116b20 100644
--- a/cc/animation/layer_animation_controller.cc
+++ b/cc/animation/layer_animation_controller.cc
@@ -534,7 +534,7 @@ void LayerAnimationController::PushNewAnimationsToImplThread(
// Scroll animations always start at the current scroll offset.
if (animations_[i]->target_property() == Animation::ScrollOffset) {
- gfx::Vector2dF current_scroll_offset;
+ gfx::ScrollOffset current_scroll_offset;
if (controller_impl->value_provider_) {
current_scroll_offset =
controller_impl->value_provider_->ScrollOffsetForAnimation();
@@ -889,7 +889,7 @@ void LayerAnimationController::TickAnimations(base::TimeTicks monotonic_time) {
case Animation::ScrollOffset: {
const ScrollOffsetAnimationCurve* scroll_offset_animation_curve =
animations_[i]->curve()->ToScrollOffsetAnimationCurve();
- const gfx::Vector2dF scroll_offset =
+ const gfx::ScrollOffset scroll_offset =
scroll_offset_animation_curve->GetValue(trimmed);
NotifyObserversScrollOffsetAnimated(
scroll_offset,
@@ -977,7 +977,7 @@ void LayerAnimationController::NotifyObserversFilterAnimated(
}
void LayerAnimationController::NotifyObserversScrollOffsetAnimated(
- const gfx::Vector2dF& scroll_offset,
+ const gfx::ScrollOffset& scroll_offset,
bool notify_active_observers,
bool notify_pending_observers) {
if (value_observers_.might_have_observers()) {
« no previous file with comments | « cc/animation/layer_animation_controller.h ('k') | cc/animation/layer_animation_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698