cc/layers/layer_unittest.cc - Issue 584503005: Make scroll offset type of float in cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_unittest.cc

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: blow up the patchset :( Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer_unittest.cc

diff --git a/cc/layers/layer_unittest.cc b/cc/layers/layer_unittest.cc

index 3950cf2946b28e5714a3f645269febfd3ba2f0c2..a52b487b11547210a371c39acbed75fbbf5efb43 100644

--- a/cc/layers/layer_unittest.cc

+++ b/cc/layers/layer_unittest.cc

@@ -611,7 +611,7 @@ TEST_F(LayerTest, CheckPropertyChangeCausesCorrectBehavior) {

test_layer->SetScrollClipLayerId(test_layer->id()));

EXPECT_SET_NEEDS_COMMIT(1, test_layer->SetUserScrollable(true, false));

EXPECT_SET_NEEDS_COMMIT(1, test_layer->SetScrollOffset(

- gfx::Vector2d(10, 10)));

+ gfx::ScrollOffset(10, 10)));

EXPECT_SET_NEEDS_COMMIT(1, test_layer->SetShouldScrollOnMainThread(true));

EXPECT_SET_NEEDS_COMMIT(1, test_layer->SetNonFastScrollableRegion(

Region(gfx::Rect(1, 1, 2, 2))));