cc/trees/layer_tree_host_common.h - Issue 584503005: Make scroll offset type of float in cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_common.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: scroll delta -> vector2dF, scroll offset -> ScrollOffset Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_common.h

diff --git a/cc/trees/layer_tree_host_common.h b/cc/trees/layer_tree_host_common.h

index 1f4717257bb4a44fdc1f6b657645a84847fc2912..a5e5456ff08e7a54edef18030f0f0db35b1f79e7 100644

--- a/cc/trees/layer_tree_host_common.h

+++ b/cc/trees/layer_tree_host_common.h

@@ -13,6 +13,7 @@

#include "cc/base/cc_export.h"

#include "cc/base/scoped_ptr_vector.h"

#include "cc/layers/layer_lists.h"

+#include "ui/gfx/geometry/scroll_offset.h"

danakj 2014/09/25 22:01:26 not needed? move to .cc

Yufeng Shen (Slow to review) 2014/09/26 20:19:07 Done.

#include "ui/gfx/rect.h"

#include "ui/gfx/transform.h"

#include "ui/gfx/vector2d.h"

@@ -130,7 +131,7 @@ class CC_EXPORT LayerTreeHostCommon {

struct ScrollUpdateInfo {

int layer_id;

- gfx::Vector2d scroll_delta;

+ gfx::Vector2dF scroll_delta;

};