Make scroll offset type of float in cc

cc/trees/layer_tree_host_impl_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 178 matching lines @@
     root->draw_properties().visible_content_rect = gfx::Rect(0, 0, 10, 10);
     host_impl_->active_tree()->SetRootLayer(root.Pass());
   }
 
   static void ExpectClearedScrollDeltasRecursive(LayerImpl* layer) {
     ASSERT_EQ(layer->ScrollDelta(), gfx::Vector2d());
     for (size_t i = 0; i < layer->children().size(); ++i)
       ExpectClearedScrollDeltasRecursive(layer->children()[i]);
   }
 
-  static void ExpectContains(const ScrollAndScaleSet& scroll_info,
-                             int id,
-                             const gfx::Vector2d& scroll_delta) {
+  // Some tests, e.g. ScrollAxisAlignedRotatedLayer generates float number
+  // which is supposed to be 0 but actually a very small value e.g. 6.12323e-16,
+  // that is exceeding our float equality test epsilon. In this case, we roll
+  // our own version of float equality test.
+  static void ExpectContainsFloat(const ScrollAndScaleSet& scroll_info,
+                                  int id,
+                                  const gfx::Vector2dF& scroll_delta) {
     int times_encountered = 0;
 
     for (size_t i = 0; i < scroll_info.scrolls.size(); ++i) {
       if (scroll_info.scrolls[i].layer_id != id)
         continue;
-      EXPECT_VECTOR_EQ(scroll_delta, scroll_info.scrolls[i].scroll_delta);
+      float diff_x = scroll_delta.x() - scroll_info.scrolls[i].scroll_delta.x();
+      float diff_y = scroll_delta.y() - scroll_info.scrolls[i].scroll_delta.y();
+      EXPECT_TRUE(std::abs(diff_x) < 0.1e-10);

[danakj, 2014/09/18 21:23:49]

You can use EXPECT_FLOAT_EQ for this probably. Or EXPECT_NEAR

[Yufeng Shen (Slow to review), 2014/09/18 22:47:55]

Done.

+      EXPECT_TRUE(std::abs(diff_y) < 0.1e-10);
       times_encountered++;
     }
 
+    ASSERT_EQ(1, times_encountered);
+  }
+
+  static void ExpectContains(const ScrollAndScaleSet& scroll_info,
+                             int id,
+                             const gfx::Vector2dF& scroll_delta) {
+    int times_encountered = 0;
+
+    for (size_t i = 0; i < scroll_info.scrolls.size(); ++i) {
+      if (scroll_info.scrolls[i].layer_id != id)
+        continue;
+      EXPECT_VECTOR2DF_EQ(scroll_delta, scroll_info.scrolls[i].scroll_delta);

[danakj, 2014/09/18 21:23:49]

EXPECT_EQ?

[Yufeng Shen (Slow to review), 2014/09/18 22:47:55]

Done.

+      times_encountered++;
+    }
+
     ASSERT_EQ(1, times_encountered);
   }
 
   static void ExpectNone(const ScrollAndScaleSet& scroll_info, int id) {
     int times_encountered = 0;
 
     for (size_t i = 0; i < scroll_info.scrolls.size(); ++i) {
       if (scroll_info.scrolls[i].layer_id != id)
         continue;
       times_encountered++;
@@ skipping 2727 matching lines @@
   // Rotate the root layer 90 degrees counter-clockwise about its center.
   gfx::Transform rotate_transform;
   rotate_transform.Rotate(-90.0);
   host_impl_->active_tree()->root_layer()->SetTransform(rotate_transform);
 
   gfx::Size surface_size(50, 50);
   host_impl_->SetViewportSize(surface_size);
   DrawFrame();
 
   // Scroll to the right in screen coordinates with a gesture.
-  gfx::Vector2d gesture_scroll_delta(10, 0);
+  gfx::Vector2dF gesture_scroll_delta(10.0f, 0.0f);
   EXPECT_EQ(InputHandler::ScrollStarted,
             host_impl_->ScrollBegin(gfx::Point(),
                                     InputHandler::Gesture));
   host_impl_->ScrollBy(gfx::Point(), gesture_scroll_delta);
   host_impl_->ScrollEnd();
 
   // The layer should have scrolled down in its local coordinates.
   scoped_ptr<ScrollAndScaleSet> scroll_info = host_impl_->ProcessScrollDeltas();
-  ExpectContains(*scroll_info.get(),
-                 scroll_layer->id(),
-                 gfx::Vector2d(0, gesture_scroll_delta.x()));
+  ExpectContainsFloat(*scroll_info.get(),
+                      scroll_layer->id(),
+                      gfx::Vector2dF(0.0f, gesture_scroll_delta.x()));
 
   // Reset and scroll down with the wheel.
   scroll_layer->SetScrollDelta(gfx::Vector2dF());
-  gfx::Vector2d wheel_scroll_delta(0, 10);
+  gfx::Vector2dF wheel_scroll_delta(0.0f, 10.0f);
   EXPECT_EQ(InputHandler::ScrollStarted,
             host_impl_->ScrollBegin(gfx::Point(),
                                     InputHandler::Wheel));
   host_impl_->ScrollBy(gfx::Point(), wheel_scroll_delta);
   host_impl_->ScrollEnd();
 
   // The layer should have scrolled down in its local coordinates.
   scroll_info = host_impl_->ProcessScrollDeltas();
   ExpectContains(*scroll_info.get(),
                  scroll_layer->id(),
@@ skipping 27 matching lines @@
       clip_layer->bounds().width() * 0.5f, clip_layer->bounds().height(), 0.f));
   LayerImpl* child_ptr = child.get();
   clip_layer->AddChild(child.Pass());
   scroll_layer->AddChild(clip_layer.Pass());
 
   gfx::Size surface_size(50, 50);
   host_impl_->SetViewportSize(surface_size);
   DrawFrame();
   {
     // Scroll down in screen coordinates with a gesture.
-    gfx::Vector2d gesture_scroll_delta(0, 10);
+    gfx::Vector2dF gesture_scroll_delta(0.0f, 10.0f);
     EXPECT_EQ(InputHandler::ScrollStarted,
               host_impl_->ScrollBegin(gfx::Point(1, 1),
                                       InputHandler::Gesture));
     host_impl_->ScrollBy(gfx::Point(), gesture_scroll_delta);
     host_impl_->ScrollEnd();
 
     // The child layer should have scrolled down in its local coordinates an
     // amount proportional to the angle between it and the input scroll delta.
-    gfx::Vector2d expected_scroll_delta(
-        0,
+    gfx::Vector2dF expected_scroll_delta(
+        0.0f,
         gesture_scroll_delta.y() *
             std::cos(MathUtil::Deg2Rad(child_layer_angle)));
     scoped_ptr<ScrollAndScaleSet> scroll_info =
         host_impl_->ProcessScrollDeltas();
     ExpectContains(*scroll_info.get(), child_layer_id, expected_scroll_delta);
 
     // The root scroll layer should not have scrolled, because the input delta
     // was close to the layer's axis of movement.
     EXPECT_EQ(scroll_info->scrolls.size(), 1u);
   }
   {
     // Now reset and scroll the same amount horizontally.
     child_ptr->SetScrollDelta(gfx::Vector2dF());
-    gfx::Vector2d gesture_scroll_delta(10, 0);
+    gfx::Vector2dF gesture_scroll_delta(10.0f, 0.0f);
     EXPECT_EQ(InputHandler::ScrollStarted,
               host_impl_->ScrollBegin(gfx::Point(1, 1),
                                       InputHandler::Gesture));
     host_impl_->ScrollBy(gfx::Point(), gesture_scroll_delta);
     host_impl_->ScrollEnd();
 
     // The child layer should have scrolled down in its local coordinates an
     // amount proportional to the angle between it and the input scroll delta.
-    gfx::Vector2d expected_scroll_delta(
-        0,
+    gfx::Vector2dF expected_scroll_delta(
+        0.0f,
         -gesture_scroll_delta.x() *
             std::sin(MathUtil::Deg2Rad(child_layer_angle)));
     scoped_ptr<ScrollAndScaleSet> scroll_info =
         host_impl_->ProcessScrollDeltas();
     ExpectContains(*scroll_info.get(), child_layer_id, expected_scroll_delta);
 
     // The root scroll layer should have scrolled more, since the input scroll
     // delta was mostly orthogonal to the child layer's vertical scroll axis.
-    gfx::Vector2d expected_root_scroll_delta(
+    gfx::Vector2dF expected_root_scroll_delta(
         gesture_scroll_delta.x() *
             std::pow(std::cos(MathUtil::Deg2Rad(child_layer_angle)), 2),
-        0);
+        0.0f);
     ExpectContains(*scroll_info.get(),
                    scroll_layer->id(),
                    expected_root_scroll_delta);
   }
 }
 
 TEST_F(LayerTreeHostImplTest, ScrollScaledLayer) {
   LayerImpl* scroll_layer =
       SetupScrollAndContentsLayers(gfx::Size(100, 100));
 
@@ skipping 4034 matching lines @@
   // surface.
   EXPECT_EQ(0, num_lost_surfaces_);
   host_impl_->DidLoseOutputSurface();
   EXPECT_EQ(1, num_lost_surfaces_);
   host_impl_->DidLoseOutputSurface();
   EXPECT_LE(1, num_lost_surfaces_);
 }
 
 }  // namespace
 }  // namespace cc