cc/blink/web_layer_impl.h - Issue 584503005: Make scroll offset type of float in cc

Side by Side Diff: cc/blink/web_layer_impl.h

Issue 584503005: Make scroll offset type of float in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update unittests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | cc/blink/web_layer_impl.cc » ('j') | cc/layers/layer.h » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_BLINK_WEB_LAYER_IMPL_H_	5 #ifndef CC_BLINK_WEB_LAYER_IMPL_H_

6 #define CC_BLINK_WEB_LAYER_IMPL_H_	6 #define CC_BLINK_WEB_LAYER_IMPL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/memory/ref_counted.h"	10 #include "base/memory/ref_counted.h"

(...skipping 84 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
95 virtual void setBackgroundFilters(const blink::WebFilterOperations& filters);	95 virtual void setBackgroundFilters(const blink::WebFilterOperations& filters);

96 virtual void setAnimationDelegate(	96 virtual void setAnimationDelegate(

97 blink::WebCompositorAnimationDelegate* delegate);	97 blink::WebCompositorAnimationDelegate* delegate);

98 virtual bool addAnimation(blink::WebCompositorAnimation* animation);	98 virtual bool addAnimation(blink::WebCompositorAnimation* animation);

99 virtual void removeAnimation(int animation_id);	99 virtual void removeAnimation(int animation_id);

100 virtual void removeAnimation(int animation_id,	100 virtual void removeAnimation(int animation_id,

101 blink::WebCompositorAnimation::TargetProperty);	101 blink::WebCompositorAnimation::TargetProperty);

102 virtual void pauseAnimation(int animation_id, double time_offset);	102 virtual void pauseAnimation(int animation_id, double time_offset);

103 virtual bool hasActiveAnimation();	103 virtual bool hasActiveAnimation();

104 virtual void setForceRenderSurface(bool force);	104 virtual void setForceRenderSurface(bool force);

	105 // TODO(miletus@): Remove the WebPoint version once blink side starts to
	danakj 2014/09/18 21:21:52 nit: no @ nit: no @ Yufeng Shen (Slow to review) 2014/09/18 22:47:55 Done. Show quoted text On 2014/09/18 21:21:52, danakj wrote: > nit: no @ Done.
	106 // use the WebFloatPoint version.

	107 virtual void setScrollPositionFloat(blink::WebFloatPoint position);

	108 virtual blink::WebFloatPoint scrollPositionFloat() const;

105 virtual void setScrollPosition(blink::WebPoint position);	109 virtual void setScrollPosition(blink::WebPoint position);

106 virtual blink::WebPoint scrollPosition() const;	110 virtual blink::WebPoint scrollPosition() const;

107 virtual void setScrollClipLayer(blink::WebLayer* clip_layer);	111 virtual void setScrollClipLayer(blink::WebLayer* clip_layer);

108 virtual bool scrollable() const;	112 virtual bool scrollable() const;

109 virtual void setUserScrollable(bool horizontal, bool vertical);	113 virtual void setUserScrollable(bool horizontal, bool vertical);

110 virtual bool userScrollableHorizontal() const;	114 virtual bool userScrollableHorizontal() const;

111 virtual bool userScrollableVertical() const;	115 virtual bool userScrollableVertical() const;

112 virtual void setHaveWheelEventHandlers(bool have_wheel_event_handlers);	116 virtual void setHaveWheelEventHandlers(bool have_wheel_event_handlers);

113 virtual bool haveWheelEventHandlers() const;	117 virtual bool haveWheelEventHandlers() const;

114 virtual void setHaveScrollEventHandlers(bool have_scroll_event_handlers);	118 virtual void setHaveScrollEventHandlers(bool have_scroll_event_handlers);

(...skipping 28 matching lines...) Expand all Loading...
143	147

144 private:	148 private:

145 scoped_ptr<WebToCCAnimationDelegateAdapter> animation_delegate_adapter_;	149 scoped_ptr<WebToCCAnimationDelegateAdapter> animation_delegate_adapter_;

146	150

147 DISALLOW_COPY_AND_ASSIGN(WebLayerImpl);	151 DISALLOW_COPY_AND_ASSIGN(WebLayerImpl);

148 };	152 };

149	153

150 } // namespace cc_blink	154 } // namespace cc_blink

151	155

152 #endif // CC_BLINK_WEB_LAYER_IMPL_H_	156 #endif // CC_BLINK_WEB_LAYER_IMPL_H_

OLD	NEW