Add debugging information to the SSL blocking page

chrome/browser/ssl/ssl_blocking_page.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_blocking_page.h"
 
 #include "base/build_time.h"
 #include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/i18n/time_formatting.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/process/launch.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
+#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/renderer_preferences_util.h"
 #include "chrome/browser/ssl/ssl_error_classification.h"
@@ skipping 478 matching lines @@
         help_string = IDS_SSL_NONOVERRIDABLE_INVALID;
         break;
       default:
         if (strict_enforcement_)
           help_string = IDS_SSL_NONOVERRIDABLE_HSTS;
     }
     load_time_data.SetString(
         "finalParagraph", l10n_util::GetStringFUTF16(help_string, url));
   }
 
+  // Set debugging information at the bottom of the warning.
+  load_time_data.SetString(
+      "subject", ssl_info_.cert->subject().GetDisplayName());
+  load_time_data.SetString(
+      "issuer", ssl_info_.cert->issuer().GetDisplayName());
+  load_time_data.SetString(
+      "expirationDate",
+      base::TimeFormatShortDate(ssl_info_.cert->valid_expiry()));
+  load_time_data.SetString(
+      "currentDate", base::TimeFormatShortDate(now));
+  std::vector<std::string> encoded_chain;
+  ssl_info_.cert->GetPEMEncodedChain(&encoded_chain);
+  load_time_data.SetString("pem", JoinString(encoded_chain, '\0'));

[Bernhard Bauer, 2014/09/22 09:13:27]

Urr... does that actually work? JoinString does have an overload that takes a
std::string.

[felt, 2014/09/22 16:29:02]

Indeed it does work. I can't find the overload anywhere in code search, do you
know where it's defined? Everyone seems to be using it with separators.

[Bernhard Bauer, 2014/09/22 19:19:27]

https://code.google.com/p/chromium/codesearch#chromium/src/base/strings/strin...

It's just that using a NUL character makes me a bit queasy (and it will result
e.g. in strange behavior when the user copies the text).

[felt, 2014/09/22 20:25:49]

Ohh I misunderstood. Fixed.

+
   base::StringPiece html(
      ResourceBundle::GetSharedInstance().GetRawDataResource(
          IRD_SECURITY_INTERSTITIAL_HTML));
   webui::UseVersion2 version;
   return webui::GetI18nTemplateHtml(html, &load_time_data);
 }
 
 void SSLBlockingPage::OverrideEntry(NavigationEntry* entry) {
   int cert_id = content::CertStore::GetInstance()->StoreCert(
       ssl_info_.cert.get(), web_contents_->GetRenderProcessHost()->GetID());
@@ skipping 129 matching lines @@
   for (; i < 5; i++) {
     strings->SetString(keys[i], std::string());
   }
 }
 
 void SSLBlockingPage::OnGotHistoryCount(bool success,
                                         int num_visits,
                                         base::Time first_visit) {
   num_visits_ = num_visits;
 }