Issue 584403002: Oilpan: remove unused support for removing FrameDestructionObservers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 584403002: Oilpan: remove unused support for removing FrameDestructionObservers. (Closed)

Created:
6 years, 3 months ago by sof

Modified:
6 years, 3 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: remove unused support for removing FrameDestructionObservers. Remove ability to explicitly remove a FrameDestructionObserver from a LocalFrame; this is taken care of by weak references instead. Also make FrameDestructionObserver::observeFrame() private; this will ease later removal once we can assume Oilpan is enabled-by-default for all observer implementations. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182370

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -2 lines)			Patch
M	Source/core/frame/FrameDestructionObserver.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameDestructionObserver.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/core/frame/LocalFrame.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/LocalFrame.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584403002/1

6 years, 3 months ago (2014-09-20 16:33:19 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-20 17:34:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182370

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages