content/public/browser/web_contents_delegate.cc - Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents_delegate.cc

Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review. Rebase. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_delegate.cc ('K') | « content/browser/frame_host/render_frame_host_delegate.cc ('k') | content/public/common/media_stream_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents_delegate.cc

diff --git a/content/public/browser/web_contents_delegate.cc b/content/public/browser/web_contents_delegate.cc

index 72cabb4b62f5bff36c8bd7276506c702f76bf238..58e3a395699e2601825e51ae203f345b62d4f738 100644

--- a/content/public/browser/web_contents_delegate.cc

+++ b/content/public/browser/web_contents_delegate.cc

@@ -164,8 +164,9 @@ void WebContentsDelegate::RequestMediaAccessPermission(

WebContents* web_contents,

const MediaStreamRequest& request,

const MediaResponseCallback& callback) {

+ LOG_F(ERROR) << "Not supported.";

jam 2014/09/25 18:50:27 ditto here and below

Henrik Grunell 2014/09/25 18:54:11 Done.

callback.Run(MediaStreamDevices(),

- MEDIA_DEVICE_INVALID_STATE,

+ MEDIA_DEVICE_NOT_SUPPORTED,

scoped_ptr<MediaStreamUI>());

}

@@ -173,8 +174,7 @@ bool WebContentsDelegate::CheckMediaAccessPermission(

WebContents* web_contents,

const GURL& security_origin,

MediaStreamType type) {

- DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||

- type == MEDIA_DEVICE_VIDEO_CAPTURE);

+ LOG_F(ERROR) << "Not supported.";

return false;

}