Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: content/browser/frame_host/render_frame_host_delegate.cc

Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review. Rebase. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_delegate.cc
diff --git a/content/browser/frame_host/render_frame_host_delegate.cc b/content/browser/frame_host/render_frame_host_delegate.cc
index b96f2b55cd5553d68da2d09ef931444dc92bad71..690c0280dfc0b0ff6144be20d1f5241321f188ef 100644
--- a/content/browser/frame_host/render_frame_host_delegate.cc
+++ b/content/browser/frame_host/render_frame_host_delegate.cc
@@ -39,16 +39,16 @@ WebContents* RenderFrameHostDelegate::GetAsWebContents() {
void RenderFrameHostDelegate::RequestMediaAccessPermission(
const MediaStreamRequest& request,
const MediaResponseCallback& callback) {
+ LOG_F(ERROR) << "Not supported.";
jam 2014/09/25 18:50:27 this looks like a webrtc macro. please don't use t
Henrik Grunell 2014/09/25 18:54:11 Haha, slipped. Fixed.
callback.Run(MediaStreamDevices(),
- MEDIA_DEVICE_INVALID_STATE,
+ MEDIA_DEVICE_NOT_SUPPORTED,
scoped_ptr<MediaStreamUI>());
}
bool RenderFrameHostDelegate::CheckMediaAccessPermission(
const GURL& security_origin,
MediaStreamType type) {
- DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
- type == MEDIA_DEVICE_VIDEO_CAPTURE);
+ LOG_F(ERROR) << "Not supported.";
return false;
}
« no previous file with comments | « no previous file | content/public/browser/web_contents_delegate.cc » ('j') | content/public/browser/web_contents_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698