Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: content/public/browser/web_contents_delegate.cc

Issue 584383002: Stricter default RequestMediaAccessPermission and CheckMediaAccessPermission implementations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/browser/web_contents_delegate.h" 5 #include "content/public/browser/web_contents_delegate.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "content/public/browser/render_view_host.h" 10 #include "content/public/browser/render_view_host.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 WebContents* web_contents, 157 WebContents* web_contents,
158 SkColor color, 158 SkColor color,
159 const std::vector<ColorSuggestion>& suggestions) { 159 const std::vector<ColorSuggestion>& suggestions) {
160 return NULL; 160 return NULL;
161 } 161 }
162 162
163 void WebContentsDelegate::RequestMediaAccessPermission( 163 void WebContentsDelegate::RequestMediaAccessPermission(
164 WebContents* web_contents, 164 WebContents* web_contents,
165 const MediaStreamRequest& request, 165 const MediaStreamRequest& request,
166 const MediaResponseCallback& callback) { 166 const MediaResponseCallback& callback) {
167 LOG(ERROR) << "WebContentsDelegate::RequestMediaAccessPermission: "
168 << "Not supported.";
167 callback.Run(MediaStreamDevices(), 169 callback.Run(MediaStreamDevices(),
168 MEDIA_DEVICE_INVALID_STATE, 170 MEDIA_DEVICE_NOT_SUPPORTED,
169 scoped_ptr<MediaStreamUI>()); 171 scoped_ptr<MediaStreamUI>());
170 } 172 }
171 173
172 bool WebContentsDelegate::CheckMediaAccessPermission( 174 bool WebContentsDelegate::CheckMediaAccessPermission(
173 WebContents* web_contents, 175 WebContents* web_contents,
174 const GURL& security_origin, 176 const GURL& security_origin,
175 MediaStreamType type) { 177 MediaStreamType type) {
176 DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE || 178 LOG(ERROR) << "WebContentsDelegate::CheckMediaAccessPermission: "
177 type == MEDIA_DEVICE_VIDEO_CAPTURE); 179 << "Not supported.";
178 return false; 180 return false;
179 } 181 }
180 182
181 bool WebContentsDelegate::RequestPpapiBrokerPermission( 183 bool WebContentsDelegate::RequestPpapiBrokerPermission(
182 WebContents* web_contents, 184 WebContents* web_contents,
183 const GURL& url, 185 const GURL& url,
184 const base::FilePath& plugin_path, 186 const base::FilePath& plugin_path,
185 const base::Callback<void(bool)>& callback) { 187 const base::Callback<void(bool)>& callback) {
186 return false; 188 return false;
187 } 189 }
(...skipping 19 matching lines...) Expand all
207 gfx::Size WebContentsDelegate::GetSizeForNewRenderView( 209 gfx::Size WebContentsDelegate::GetSizeForNewRenderView(
208 WebContents* web_contents) const { 210 WebContents* web_contents) const {
209 return gfx::Size(); 211 return gfx::Size();
210 } 212 }
211 213
212 bool WebContentsDelegate::IsNeverVisible(WebContents* web_contents) { 214 bool WebContentsDelegate::IsNeverVisible(WebContents* web_contents) {
213 return false; 215 return false;
214 } 216 }
215 217
216 } // namespace content 218 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_delegate.cc ('k') | content/public/common/media_stream_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698