Issue 584313002: Fix crash in UnpackedInstaller::LoadFromCommandLine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 584313002: Fix crash in UnpackedInstaller::LoadFromCommandLine (Closed)

Created:
6 years, 3 months ago by Devlin

Modified:
6 years, 3 months ago

Reviewers:
Marijn Kruisselbrink

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash in UnpackedInstaller::LoadFromCommandLine We were initializing permissions before checking that the extension existed. Fix this. BUG=415986 Committed: https://crrev.com/f173cbc4f2ffeecde3706a5880e5e5af0ccebc6f Cr-Commit-Position: refs/heads/master@{#296463}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/extensions/unpacked_installer.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584313002/1

6 years, 3 months ago (2014-09-24 17:20:13 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as eea1d53704328886abdfa6df76019ea33803f735

6 years, 3 months ago (2014-09-24 18:03:53 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-24 18:05:07 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f173cbc4f2ffeecde3706a5880e5e5af0ccebc6f
Cr-Commit-Position: refs/heads/master@{#296463}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages