Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 584303002: Clean up forward declarations in Source/core/page (Closed)

Created:
6 years, 3 months ago by zhaoze.zhou
Modified:
6 years, 3 months ago
Reviewers:
haraken, rwlbuis
CC:
blink-reviews, kenneth.christiansen, eae+blinkwatch, dcheng, blink-layers+watch_chromium.org, blink-reviews-events_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/page These forward references are not needed anymore. After this patch, Source/core/page has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M Source/core/page/AutoscrollController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/BackForwardClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/Chrome.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/DragController.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/DragData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EditorClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/FocusController.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/Page.h View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/page/PageSerializer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/PointerLockController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/SpatialNavigation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
On 2014/09/19 21:57:53, zhaoze.zhou wrote: > mailto:zhaoze.zhou@partner.samsung.com changed reviewers: > + mailto:rob.buis@samsung.com Looks good...
6 years, 3 months ago (2014-09-19 22:10:08 UTC) #2
zhaoze.zhou
6 years, 3 months ago (2014-09-19 22:33:37 UTC) #4
haraken
LGTM
6 years, 3 months ago (2014-09-19 22:34:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584303002/1
6 years, 3 months ago (2014-09-19 22:37:59 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:28:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182360

Powered by Google App Engine
This is Rietveld 408576698