Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 584293003: MachMessageServer test: deal with short receive queue lengths on 10.10 (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

MachMessageServer test: deal with short receive queue lengths on 10.10. The queue length of a new receive port appears to be 2 on Mac OS X 10.10 DP8 14A361c. The value of MACH_PORT_QLIMIT_DEFAULT in the 10.10 SDK is still 5, so a read of the kernel source should be interesting, if we ever get to see it. In the meantime, mach_port_set_attributes() can be used to set a traditional queue length. TEST=util_test MachMessageServer.PersistentNonblockingFourMessages R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8eec7874fd035bba7aadb469013e54730890b181

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M util/mach/mach_message_server_test.cc View 1 2 12 chunks +55 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-19 22:17:39 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/584293003/diff/1/util/mach/mach_message_server_test.cc File util/mach/mach_message_server_test.cc (right): https://codereview.chromium.org/584293003/diff/1/util/mach/mach_message_server_test.cc#newcode316 util/mach/mach_message_server_test.cc:316: mach_port_limits limits; = {} in case this struct ...
6 years, 3 months ago (2014-09-22 15:15:57 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-22 17:15:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 8eec787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698