runtime/bin/vmservice/observatory/lib/src/service/object.dart - Issue 584293002: Begin implementing a debugger page in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 584293002: Begin implementing a debugger page in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/stack_trace.html ('k') | runtime/bin/vmservice/observatory/web/index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/service/object.dart b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

index 4fb2ba180ecd3fa0fc0f052877e1e632de2ccf03..afca179c0a73cd366b20ca913fc27ee6268b312b 100644

--- a/runtime/bin/vmservice/observatory/lib/src/service/object.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

@@ -230,7 +230,7 @@ abstract class ServiceObject extends Observable {

// updating the existing one.

// TODO(turnidge): Check for vmType changing as well?

- assert(mapType == 'Error' || mapType == 'null');

+ assert(mapType == 'Error' || mapType == 'Sentinel');

return new ServiceObject._fromMap(owner, map);

}

update(map);