Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 584273002: Clean up forward declarations in Source/core/frame (Closed)

Created:
6 years, 3 months ago by zhaoze.zhou
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/frame These forward references are not needed anymore. After this patch, Source/core/frame has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/core/frame/Console.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/FrameConsole.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 3 chunks +0 lines, -9 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/SettingsDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/csp/CSPDirective.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
zhaoze.zhou
6 years, 3 months ago (2014-09-19 22:33:05 UTC) #3
haraken
LGTM
6 years, 3 months ago (2014-09-19 22:35:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584273002/1
6 years, 3 months ago (2014-09-19 22:37:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 22:45:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182357

Powered by Google App Engine
This is Rietveld 408576698