Use ChromeAutocompleteSchemeClassifier for Athena on Chrome.

Use ChromeAutocompleteSchemeClassifier for Athena on Chrome.

Otherwise chrome:// are not recognized as the search result.

This CL also modifies the logic of URLSearchProvider's result
aggregation, because the SearchProvider doesn't emit result change
for URL-ish results.

BUG=416083
R=oshima@chromium.org
TBR=mpearson@chromium.org, agl@chromium.org
TEST=manually

Committed: https://crrev.com/413d75456a61016bf0652800920228241881277d
Cr-Commit-Position: refs/heads/master@{#295803}

[oshima, 2014-09-19 21:04:28]

lgtm with nits

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
File athena/content/shell/scheme_classifier_factory.cc (right):

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
athena/content/shell/scheme_classifier_factory.cc:17:
AthenaShellSchemeClassifier() {}
virtual dtor

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
athena/content/shell/scheme_classifier_factory.cc:31: }
// namespace

[Jun Mukai, 2014-09-19 21:06:54]

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
File athena/content/shell/scheme_classifier_factory.cc (right):

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
athena/content/shell/scheme_classifier_factory.cc:17:
AthenaShellSchemeClassifier() {}
On 2014/09/19 21:04:28, oshima wrote:
> virtual dtor

Done.

https://codereview.chromium.org/584263002/diff/1/athena/content/shell/scheme_...
athena/content/shell/scheme_classifier_factory.cc:31: }
On 2014/09/19 21:04:28, oshima wrote:
> // namespace

Done.

[Jun Mukai, 2014-09-19 21:07:51]

mukai@chromium.org changed reviewers:
+ agl@chromium.org, mpearson@chromium.org

[Jun Mukai, 2014-09-19 21:08:06]

TBR=mpearson, agr for the new lines of DEPS file.

[Jun Mukai, 2014-09-19 21:08:09]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-19 21:09:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584263002/20001

[commit-bot: I haz the power, 2014-09-19 22:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:27:51]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-09-19 22:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:27:59]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Jun Mukai, 2014-09-19 22:36:00]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:38:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584263002/20001

[commit-bot: I haz the power, 2014-09-19 22:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584263002/20001

[commit-bot: I haz the power, 2014-09-19 23:23:17]

Committed patchset #2 (id:20001) as 737cd9d2e01105f51ff35c5537de38dbd1ab31e5

[commit-bot: I haz the power, 2014-09-19 23:23:19]

Committed patchset #2 (id:20001) as 737cd9d2e01105f51ff35c5537de38dbd1ab31e5

[commit-bot: I haz the power, 2014-09-19 23:27:01]

Patchset 2 (id:??) landed as
https://crrev.com/413d75456a61016bf0652800920228241881277d
Cr-Commit-Position: refs/heads/master@{#295803}