Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 584243002: Fix plugin placeholder invalidation issue (Closed)

Created:
6 years, 3 months ago by Xianzhu
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix plugin placeholder invalidation issue Blink no longer always invalidate synchronously. If an invalidation requirement is not generated during a frame update, the blink will schedule an animation and will issue the invalidation in the next frame update. webview_plugin should handle scheduleAnimation() to trigger the next frame update. For now we call container_->invalidate() to achieve that. BUG=415926 Committed: https://crrev.com/e88496b3ee30a5fbb97a91a6afa6ce143036ca84 Cr-Commit-Position: refs/heads/master@{#295991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M components/plugins/renderer/webview_plugin.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Xianzhu
6 years, 3 months ago (2014-09-19 20:26:39 UTC) #2
Bernhard Bauer
LGTM, thanks!
6 years, 3 months ago (2014-09-21 10:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584243002/1
6 years, 3 months ago (2014-09-22 15:58:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 241e8f8f35946d3b56aa55e78965eff0a324d65f
6 years, 3 months ago (2014-09-22 16:44:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 16:46:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e88496b3ee30a5fbb97a91a6afa6ce143036ca84
Cr-Commit-Position: refs/heads/master@{#295991}

Powered by Google App Engine
This is Rietveld 408576698