Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: util/mach/exception_ports.h

Issue 584223002: ExceptionPorts test: accept a port of MACH_PORT_NULL as “no handler.” (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/mach/exception_ports.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exception_ports.h
diff --git a/util/mach/exception_ports.h b/util/mach/exception_ports.h
index 2592d74b55548856d504282d92fe8084eb2ecaef..bd8212ce5e93f9d2480b534a659a8fc2d19539b8 100644
--- a/util/mach/exception_ports.h
+++ b/util/mach/exception_ports.h
@@ -112,7 +112,11 @@ class ExceptionPorts {
//! \param[out] handlers The exception handlers registered for \a target_port
//! to handle exceptions indicated in \a mask. The caller must take
//! ownership of the \a port members of the returned ExceptionHandler
- //! objects. On failure, this argument is untouched.
+ //! objects. If no execption port is registered for a bit in \a mask, \a
+ //! handlers will not contain an entry corresponding to that bit. This is
+ //! a departure from the `*_get_exception_ports()` functions, which may
+ //! return a handler whose port is set to `EXCEPTION_PORT_NULL` in this
+ //! case. On failure, this argument is untouched.
//!
//! \return `true` if `*_get_exception_ports()` returned `KERN_SUCCESS`, with
//! \a handlers set appropriately. `false` otherwise, with an appropriate
« no previous file with comments | « no previous file | util/mach/exception_ports.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698