ExceptionPorts test: accept a port of MACH_PORT_NULL as “no handler.”

util/mach/exception_ports.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 99 matching lines @@
   //! \param[in] mask The exception mask, containing the `EXC_MASK_*` values to
   //!     be looked up and returned in \a handlers.
   //! \param[out] handlers The exception handlers registered for \a target_port
   //!     to handle exceptions indicated in \a mask. The caller must take
   //!     ownership of the \a port members of the returned ExceptionHandler
   //!     objects. On failure, this argument is untouched.
   //!
   //! \return `true` if `*_get_exception_ports()` returned `KERN_SUCCESS`, with
   //!     \a handlers set appropriately. `false` otherwise, with an appropriate
   //!     message logged.
+  //!
+  //! \note One element at most will be returned in \a handlers for each bit set
+  //!     in \a mask. If no exception port is registered for a bit in \a mask,
+  //!     there will either be no entry corresponding to that bit in \a
+  //!     handlers, or there will be an entry whose ExceptionHandler::port field
+  //!     is set to `MACH_PORT_NULL`. The precise behavior depends on the

[Robert Sesek, 2014/09/22 15:08:23]

Would it not be better to have ExceptionPorts normalize the behavior?

+  //!     underlying operating system and the target type.
   bool GetExceptionPorts(exception_mask_t mask,
                          std::vector<ExceptionHandler>* handlers) const;
 
   //! \brief Calls `*_set_exception_ports()` on the target.
   //!
   //! \param[in] mask A mask specifying the exception types to direct to \a
   //!     port, containing `EXC_MASK_*` values.
   //! \param[in] port A send right to a Mach port that will handle exceptions
   //!     sustained by \a target_port of the types indicated in \a mask. The
   //!     send right is copied, not consumed, by this call.
@@ skipping 43 matching lines @@
   // even with a MACH_PORT_NULL target_port, because it is incorrect to
   // deallocate the result of mach_task_self().
   bool dealloc_target_port_;
 
   DISALLOW_COPY_AND_ASSIGN(ExceptionPorts);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_UTIL_MACH_EXCEPTION_PORTS_H_