Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 584163004: Move web_request directory to //extensions. (Closed)

Created:
6 years, 3 months ago by Xi Han
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move web_request directory to //extensions. This CL moves the core web_request code, except: -web_request_api_unittest.cc -web_request_apitest.cc -web_request_permissions_unittest.cc Also moves json files: -web_request.json -web_request_interal.json BUG=352293 Committed: https://crrev.com/2183a5ca1d032992752682439848dddbe0ed0085 Cr-Commit-Position: refs/heads/master@{#296140}

Patch Set 1 : #

Patch Set 2 : rebase. #

Patch Set 3 : Fix android compile error. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5485 lines) Patch
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/web_request/form_data_parser.h View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/extensions/api/web_request/form_data_parser.cc View 1 chunk +0 lines, -595 lines 0 comments Download
D chrome/browser/extensions/api/web_request/form_data_parser_unittest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/browser/extensions/api/web_request/upload_data_presenter.h View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/extensions/api/web_request/upload_data_presenter.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_api.h View 1 2 3 1 chunk +0 lines, -546 lines 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 3 1 chunk +0 lines, -2463 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_time_tracker.h View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_time_tracker.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/extensions/api/web_request/web_request_time_tracker_unittest.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_extensions_network_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/web_request.json View 1 chunk +0 lines, -543 lines 0 comments Download
D chrome/common/extensions/api/web_request_internal.json View 1 chunk +0 lines, -56 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
A + extensions/browser/api/web_request/form_data_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/web_request/form_data_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/web_request/form_data_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/web_request/upload_data_presenter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/web_request/upload_data_presenter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/api/web_request/upload_data_presenter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/web_request/web_request_api.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/web_request/web_request_api.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/web_request/web_request_time_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/web_request/web_request_time_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/web_request/web_request_time_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
A + extensions/common/api/web_request.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/common/api/web_request_internal.json View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Xi Han
6 years, 3 months ago (2014-09-22 17:40:12 UTC) #3
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-22 18:03:26 UTC) #4
Xi Han
rockot@chromium.org: Please review all changes. Thanks a lot!
6 years, 3 months ago (2014-09-22 18:16:11 UTC) #6
Ken Rockot(use gerrit already)
Woot! lgtm
6 years, 3 months ago (2014-09-22 20:50:50 UTC) #7
Xi Han
sky@chromium.org: Please review changes in: -chrome/browser/net/chrome_extensions_network_delegate.cc -chrome/browser/profiles/off_the_record_profile_impl.cc
6 years, 3 months ago (2014-09-22 21:05:31 UTC) #9
sky
LGTM
6 years, 3 months ago (2014-09-22 21:41:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584163004/80001
6 years, 3 months ago (2014-09-22 22:01:57 UTC) #12
commit-bot: I haz the power
Failed to apply patch for extensions/common/api/schemas.gypi: While running git apply --index -p1; error: patch failed: ...
6 years, 3 months ago (2014-09-22 22:50:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584163004/100001
6 years, 3 months ago (2014-09-23 02:08:41 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:100001) as 1be92560b2979a6b60a91b5d389148ccd6aa9ae7
6 years, 3 months ago (2014-09-23 04:20:35 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 04:21:07 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2183a5ca1d032992752682439848dddbe0ed0085
Cr-Commit-Position: refs/heads/master@{#296140}

Powered by Google App Engine
This is Rietveld 408576698