Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 584143002: Move rules_registry_unittest.cc (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move rules_registry_unittest.cc BUG=352293 Committed: https://crrev.com/edc4f4707398f16b70f467fb37285c341e60e468 Cr-Commit-Position: refs/heads/master@{#296019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -168 lines) Patch
D chrome/browser/extensions/api/declarative/rules_registry_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/browser/api/declarative/rules_registry_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
wjmaclean
Super simple move, ptal ...
6 years, 3 months ago (2014-09-19 17:18:15 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-19 19:48:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584143002/1
6 years, 3 months ago (2014-09-19 20:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584143002/1
6 years, 3 months ago (2014-09-19 20:26:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11450)
6 years, 3 months ago (2014-09-19 21:06:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11450)
6 years, 3 months ago (2014-09-19 21:06:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584143002/1
6 years, 3 months ago (2014-09-19 21:23:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11543)
6 years, 3 months ago (2014-09-19 22:25:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584143002/1
6 years, 3 months ago (2014-09-22 18:48:03 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as 10cf1d26027fa825a48d25c5f7f5da507abdbc8c
6 years, 3 months ago (2014-09-22 18:51:37 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 18:52:19 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/edc4f4707398f16b70f467fb37285c341e60e468
Cr-Commit-Position: refs/heads/master@{#296019}

Powered by Google App Engine
This is Rietveld 408576698