Issue 58413003: GTTF: Make it possible to pass sharding settings from command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58413003: GTTF: Make it possible to pass sharding settings from command line. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: Make it possible to pass sharding settings from command line. This overrides any environment variables (a message is printed that clearly says which settings are applied). Main rationale is that runtest.py is well suited to pass command line flags but not environment variables. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232869

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -5 lines)			Patch
M	base/test/launcher/test_launcher.cc	View	1 chunk	+33 lines, -5 lines	0 comments	Download
M	base/test/test_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	base/test/test_switches.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r232869.

Expand Messages | Collapse Messages