Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 584103002: Remove implicit conversions from scoped_refptr to T* in media/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in media/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Mac build. BUG=110610 Committed: https://crrev.com/61b83a1c18ec9e4e8ea5fe4795131c6eb6ac2521 Cr-Commit-Position: refs/heads/master@{#295837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M media/video/capture/mac/video_capture_device_factory_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
dcheng
6 years, 3 months ago (2014-09-19 17:03:42 UTC) #2
vrk (LEFT CHROMIUM)
lgtm
6 years, 3 months ago (2014-09-19 20:00:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584103002/1
6 years, 3 months ago (2014-09-19 20:26:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584103002/1
6 years, 3 months ago (2014-09-19 20:26:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11437)
6 years, 3 months ago (2014-09-19 20:56:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584103002/1
6 years, 3 months ago (2014-09-20 00:56:46 UTC) #10
commit-bot: I haz the power
Failed to apply the patch.
6 years, 3 months ago (2014-09-20 01:01:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as ee896238aaa0beff09a8b23a343b996e3e17cb06
6 years, 3 months ago (2014-09-20 01:01:36 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 01:02:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61b83a1c18ec9e4e8ea5fe4795131c6eb6ac2521
Cr-Commit-Position: refs/heads/master@{#295837}

Powered by Google App Engine
This is Rietveld 408576698