LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js - Issue 584053002: Handle semicolons at end of keyTimes and values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js

Issue 584053002: Handle semicolons at end of keyTimes and values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix unintended behavior Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/svg/custom/keyTimes-parsing-error-expected.txt ('k') | LayoutTests/svg/custom/script-tests/keyTimes-parsing-error.js » ('j') | Source/core/svg/SVGAnimationElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js

diff --git a/LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js b/LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js

new file mode 100644

index 0000000000000000000000000000000000000000..0063eea70c27e4b40371b84483e6d08846d05ff6

--- /dev/null

+++ b/LayoutTests/svg/custom/script-tests/animation-values-parsing-error.js

@@ -0,0 +1,12 @@

+description("Tests parsing of values attribute.");

+var animate = document.createElementNS("http://www.w3.org/2000/svg", "animate");

+animate.setAttribute("values", ";;");

+animate.setAttribute("values", "300;255;180;30;;");

+animate.setAttribute("values", "50%;foo;10%");

+animate.setAttribute("values", "50%;;;;10%");

+animate.setAttribute("values", "50%; ;10%");

+animate.setAttribute("animationName", "in");

Erik Dahlström (inactive) 2014/10/06 07:33:53 should be "attributeName", not "animationName".

+animate.setAttribute("values", "");

+var successfullyParsed = true;