Make chrome.power sample extension work across updates.

Make chrome.power sample extension work across updates.

Make the "Keep Awake" extension load its saved state in
response to chrome.runtime.onInstalled in addition to
onStartup. Otherwise, it releases its wake locks after being
upgraded and fails to reacquire them until the next time
Chrome is restarted.

BUG=none
TBR=miket@chromium.org

Committed: https://crrev.com/cf6503512cff8034833ddb07c69fa71717a29a03
Cr-Commit-Position: refs/heads/master@{#295805}

[Daniel Erat, 2014-09-19 19:42:01]

derat@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2014-09-19 19:47:27]

lgtm

https://codereview.chromium.org/584033003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/584033003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/power/background.js:100:
loadSavedState(function(state) { setState(state); });
I assume loadSavedState can be called multiple times without a problem. I
mention this because you might get an onInstalled event and onStartup event one
after the other, e.g. when Chrome itself updates.

[Daniel Erat, 2014-09-19 19:53:12]

https://codereview.chromium.org/584033003/diff/1/chrome/common/extensions/doc...
File chrome/common/extensions/docs/examples/api/power/background.js (right):

https://codereview.chromium.org/584033003/diff/1/chrome/common/extensions/doc...
chrome/common/extensions/docs/examples/api/power/background.js:100:
loadSavedState(function(state) { setState(state); });
On 2014/09/19 19:47:27, Matt Perry wrote:
> I assume loadSavedState can be called multiple times without a problem. I
> mention this because you might get an onInstalled event and onStartup event
one
> after the other, e.g. when Chrome itself updates.

yep, this should be fine. the locks don't stack and setState() blows away
whatever was there already, so the second duplicated call should just be a
no-op.

[Daniel Erat, 2014-09-19 19:53:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-09-19 20:26:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584033003/1

[commit-bot: I haz the power, 2014-09-19 20:26:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584033003/1

[commit-bot: I haz the power, 2014-09-19 20:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 20:46:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Erat, 2014-09-19 20:54:00]

derat@chromium.org changed reviewers:
+ miket@chromium.org

[Daniel Erat, 2014-09-19 20:54:01]

tbr miket

[Daniel Erat, 2014-09-19 20:54:26]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-09-19 20:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584033003/1

[commit-bot: I haz the power, 2014-09-19 20:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584033003/1

[commit-bot: I haz the power, 2014-09-19 22:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:12:08]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[commit-bot: I haz the power, 2014-09-19 22:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:13:13]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Daniel Erat, 2014-09-19 22:13:44]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-09-19 22:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/584033003/1

[commit-bot: I haz the power, 2014-09-19 23:25:31]

Committed patchset #1 (id:1) as 0443b62ed7e2da245a77c21782373f11cd33d7a7

[commit-bot: I haz the power, 2014-09-19 23:28:02]

Patchset 1 (id:??) landed as
https://crrev.com/cf6503512cff8034833ddb07c69fa71717a29a03
Cr-Commit-Position: refs/heads/master@{#295805}

[miket_OOO, 2014-09-21 22:52:10]

lgtm