Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 584033002: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix ref in test. Tables don't do subpixel, and that made a difference on Windows and Mac. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderPagedFlowThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index 473f7f1a9bcdd39b4d9fc44d1191a959a9e5fc75..da4cbfa1391fbe76dab0e0900e7db94ef3ea754a 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -322,6 +322,13 @@ bool RenderObject::requiresAnonymousTableWrappers(const RenderObject* newChild)
return false;
}
+bool RenderObject::isValidColumnSpanAll() const
+{
+ ASSERT(style()->columnSpan() == ColumnSpanAll);
+ RenderFlowThread* flowThread = flowThreadContainingBlock();
+ return flowThread && flowThread->isColumnSpanner(this);
+}
+
void RenderObject::addChild(RenderObject* newChild, RenderObject* beforeChild)
{
ASSERT(isAllowedToModifyRenderTreeStructure(document()));
@@ -2369,6 +2376,9 @@ void RenderObject::insertedIntoTree()
if (!isFloating() && parent()->childrenInline())
parent()->dirtyLinesFromChangedChild(this);
+
+ if (RenderFlowThread* flowThread = parent()->flowThreadContainingBlock())
+ flowThread->flowThreadDescendantInserted(this);
}
void RenderObject::willBeRemovedFromTree()
@@ -2419,6 +2429,8 @@ void RenderObject::removeFromRenderFlowThreadRecursive(RenderFlowThread* renderF
child->removeFromRenderFlowThreadRecursive(renderFlowThread);
}
+ if (renderFlowThread && renderFlowThread != this)
+ renderFlowThread->flowThreadDescendantWillBeRemoved(this);
setFlowThreadState(NotInsideFlowThread);
}
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderPagedFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698