LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html - Issue 584033002: [New Multicolumn] Add support for column-span:all

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/multicol-with-spanner-becomes-regular-block.html

Issue 584033002: [New Multicolumn] Add support for column-span:all (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix ref in test. Tables don't do subpixel, and that made a difference on Windows and Mac. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script>	2 <script>

3 if (window.internals)

4 internals.settings.setRegionBasedColumnsEnabled(true);

5 onload = function() {	3 onload = function() {

6 var elm = document.getElementById('elm');	4 var elm = document.getElementById('elm');

7 elm.offsetTop; // trigger layout	5 elm.offsetTop; // trigger layout

8 elm.style.WebkitColumns = 'auto';	6 elm.style.WebkitColumns = 'auto';

9 elm.style.columns = 'auto';	7 elm.style.columns = 'auto';

10 }	8 }

11 </script>	9 </script>

12 <p>There should be a blue <em>square</em> below.</p>	10 <p>There should be a blue <em>square</em> below.</p>

13 <div id="elm" style="-webkit-columns:4; columns:4; orphans:1; widows:1; width:16 em; line-height:4em; background:blue;">	11 <div id="elm" style="-webkit-columns:4; columns:4; orphans:1; widows:1; width:17 em; line-height:4em;">

14 <br>	12 <div style="margin-top:100px; margin-left:1em;">

15 <br>	13 <div style="-webkit-column-span:all; column-span:all; background:blue;">  </div>

16 <br>	14 </div>

17 <br>	15 <div style="margin-left:1em; background:blue;">

	16 <br>

	17 <br>

	18 <br>

	19 </div>

18 </div>	20 </div>

OLD	NEW