Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 584023005: Clean up forward declarations in Source/core/editing (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
haraken, yosin
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/core/editing Clean up forward declarations in Source/core/editing These forward references are not needed anymore. After this patch, Source/core/editing has no unneeded forward references anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M Source/core/editing/ApplyStyleCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/DOMSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditingStyle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/editing/InputMethodController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/SpellCheckRequester.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-19 21:56:05 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-19 22:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/584023005/1
6 years, 3 months ago (2014-09-19 22:35:14 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-20 00:23:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182363

Powered by Google App Engine
This is Rietveld 408576698