Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: runtime/vm/unit_test.h

Issue 584023004: Service isolate rework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service/vmservice.dart ('k') | tests/standalone/vmservice/test_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/unit_test.h
diff --git a/runtime/vm/unit_test.h b/runtime/vm/unit_test.h
index 01aac9d5230d3007b6d44484a73b84cdd55e625a..41695eda70c990e1848428f0c4bc2d9bf6bde92e 100644
--- a/runtime/vm/unit_test.h
+++ b/runtime/vm/unit_test.h
@@ -264,11 +264,12 @@ class TestCase : TestCaseBase {
Dart_NativeEntryResolver resolver);
static Dart_Handle lib();
static const char* url() { return USER_TEST_URI; }
- static Dart_Isolate CreateTestIsolateFromSnapshot(uint8_t* buffer) {
- return CreateIsolate(buffer);
+ static Dart_Isolate CreateTestIsolateFromSnapshot(
+ uint8_t* buffer, const char* name = NULL) {
+ return CreateIsolate(buffer, name);
}
- static Dart_Isolate CreateTestIsolate() {
- return CreateIsolate(bin::snapshot_buffer);
+ static Dart_Isolate CreateTestIsolate(const char* name = NULL) {
+ return CreateIsolate(bin::snapshot_buffer, name);
}
static Dart_Handle library_handler(Dart_LibraryTag tag,
Dart_Handle library,
@@ -278,9 +279,10 @@ class TestCase : TestCaseBase {
virtual void Run();
private:
- static Dart_Isolate CreateIsolate(const uint8_t* buffer) {
+ static Dart_Isolate CreateIsolate(const uint8_t* buffer,
+ const char* name) {
char* err;
- Dart_Isolate isolate = Dart_CreateIsolate(NULL, NULL, buffer, NULL, &err);
+ Dart_Isolate isolate = Dart_CreateIsolate(name, NULL, buffer, NULL, &err);
if (isolate == NULL) {
OS::Print("Creation of isolate failed '%s'\n", err);
free(err);
« no previous file with comments | « runtime/vm/service/vmservice.dart ('k') | tests/standalone/vmservice/test_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698