Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: runtime/vm/debugger.cc

Issue 584023004: Service isolate rework (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc
index 8cfa2078f5280cca1efb8c0e4bb84fa751962b85..47283057d34d48ba732ab9e6484821e37118b920 100644
--- a/runtime/vm/debugger.cc
+++ b/runtime/vm/debugger.cc
@@ -1066,7 +1066,9 @@ void Debugger::Shutdown() {
delete bpt;
}
// Signal isolate shutdown event.
- SignalIsolateEvent(DebuggerEvent::kIsolateShutdown);
+ if (!Service::IsServiceIsolate(isolate_)) {
+ SignalIsolateEvent(DebuggerEvent::kIsolateShutdown);
+ }
}
@@ -2254,8 +2256,9 @@ void Debugger::Initialize(Isolate* isolate) {
return;
}
isolate_ = isolate;
+
// Use the isolate's control port as the isolate_id for debugging.
- // This port will be used as a unique ID to represet the isolate in the
+ // This port will be used as a unique ID to represent the isolate in the
// debugger wire protocol messages.
isolate_id_ = isolate->main_port();
initialized_ = true;
@@ -2264,7 +2267,9 @@ void Debugger::Initialize(Isolate* isolate) {
void Debugger::NotifyIsolateCreated() {
// Signal isolate creation event.
- SignalIsolateEvent(DebuggerEvent::kIsolateCreated);
+ if (!Service::IsServiceIsolate(isolate_)) {
+ SignalIsolateEvent(DebuggerEvent::kIsolateCreated);
+ }
}
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698